apktool has duplicate classes in jar #505

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 394 created by vipinarav on 2013-01-16T15:20:00.000Z:

Open the apktool 1.5.1.jar or the built jar using unzip utility.
You will find duplicate entries for license.txt,notice.txt in the same folder. You will also find duplicate class entries in same folder.
go to
\apktool.jar\antlr\

and you will see multiple entries for the same class files
ANTLError.class,etc.

Please fix this so that the resultant jar is valid.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by connor.tumbleson on 2013-01-16T16:55:08.000Z:

Basically re-doing the entire build.gradle script (now that I understand it more). Will get proguard working before v1.5.2.

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by connor.tumbleson on 2013-01-16T16:55:08.000Z:

Basically re-doing the entire build.gradle script (now that I understand it more). Will get proguard working before v1.5.2.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by connor.tumbleson on 2013-01-17T00:30:44.000Z:

Very strange. The base smali.jar (after build) has one instance of the antlr, like it should. Just like every other jar (baksmali, apktool-lib, etc). Then when it generates the final dependency included jar, it duplicates the antlr classes in the jar.

Really makes no sense, but then again. I've never used Proguard before. Still learning.

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by connor.tumbleson on 2013-01-17T00:30:44.000Z:

Very strange. The base smali.jar (after build) has one instance of the antlr, like it should. Just like every other jar (baksmali, apktool-lib, etc). Then when it generates the final dependency included jar, it duplicates the antlr classes in the jar.

Really makes no sense, but then again. I've never used Proguard before. Still learning.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #3 originally posted by vipinarav on 2013-01-17T03:14:34.000Z:

I think Proguard might not be able to fix the multiple entry problem in jar. I think this might be due to something in the scripts when dependent jars are referenced.

Owner

iBotPeaches commented Mar 18, 2015

Comment #3 originally posted by vipinarav on 2013-01-17T03:14:34.000Z:

I think Proguard might not be able to fix the multiple entry problem in jar. I think this might be due to something in the scripts when dependent jars are referenced.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #4 originally posted by connor.tumbleson on 2013-01-17T03:49:29.000Z:

Feel free to look into it and submit patches. I'm working on Proguard, but it'll take me some time.

Owner

iBotPeaches commented Mar 18, 2015

Comment #4 originally posted by connor.tumbleson on 2013-01-17T03:49:29.000Z:

Feel free to look into it and submit patches. I'm working on Proguard, but it'll take me some time.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #5 originally posted by connor.tumbleson on 2013-01-17T13:59:59.000Z:

This issue was closed by revision 92eae96.

Owner

iBotPeaches commented Mar 18, 2015

Comment #5 originally posted by connor.tumbleson on 2013-01-17T13:59:59.000Z:

This issue was closed by revision 92eae96.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #6 originally posted by connor.tumbleson on 2013-01-17T14:07:28.000Z:

It has been fixed :)

Note to build now you do

./gradlew fatJar

instead of build. I'll see if I can run fatJar via build, but for now it works :)

Owner

iBotPeaches commented Mar 18, 2015

Comment #6 originally posted by connor.tumbleson on 2013-01-17T14:07:28.000Z:

It has been fixed :)

Note to build now you do

./gradlew fatJar

instead of build. I'll see if I can run fatJar via build, but for now it works :)

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #7 originally posted by connor.tumbleson on 2013-01-17T14:10:02.000Z:

<empty>

Owner

iBotPeaches commented Mar 18, 2015

Comment #7 originally posted by connor.tumbleson on 2013-01-17T14:10:02.000Z:

<empty>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment