New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android:debuggable #507

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 396 created by connor.tumbleson on 2013-01-18T04:21:15.000Z:

Much like <uses-sdk>. If you build the apk w/ the commands & its present in the Manifest it errors.

Currently we don't remove android:debuggable, so if you try and build it to true, it pulls the value from manifest which is false.

So we need to store the debuggable value in apktool.yml

@iBotPeaches iBotPeaches self-assigned this Mar 18, 2015

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by connor.tumbleson on 2013-01-18T04:41:32.000Z:

The plan of attack.

  • If decompiling using -d (--debug), then read the manifest for the debug field and record it. Or just remove it from the manifest, using PullParser.
  • On rebuild (Since they decompiled using -d they better rebuild using -d), use --debug-mode passed to aapt to add debuggable="true" into the manifest.

If they decompile using -d and don't rebuild using -d. There could be warnings / errors. Don't know how to solve that.

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by connor.tumbleson on 2013-01-18T04:41:32.000Z:

The plan of attack.

  • If decompiling using -d (--debug), then read the manifest for the debug field and record it. Or just remove it from the manifest, using PullParser.
  • On rebuild (Since they decompiled using -d they better rebuild using -d), use --debug-mode passed to aapt to add debuggable="true" into the manifest.

If they decompile using -d and don't rebuild using -d. There could be warnings / errors. Don't know how to solve that.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by iBotPeaches on 2013-02-16T13:35:16.000Z:

<empty>

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by iBotPeaches on 2013-02-16T13:35:16.000Z:

<empty>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment