versionName property corrupted for adobe reader #512

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 401 created by Henry.Hu.SH on 2013-01-29T23:16:43.000Z:

What steps will reproduce the problem?

  1. Get Adobe Reader 10.4.2's apk
  2. Unpack and pack it
  3. Run it and click "Allow"

What is the expected output? What do you see instead?
The app should continue, but it got force close.

What version of the product are you using? On what operating system?
apktool 1.5.1, on Arch Linux x86_64

Please provide any additional information below.
The app tried to grab the "versionName" property from its PackageInfo, and got null.
If you start "settings->apps" and open the app's entry, you would also find that the version information is missing.
With the original version there is "version 10.4.2" on it.
The versionName in manifest file is a reference to a string.
I'm not sure why it cannot be loaded, but there must be a problem somewhere. All I have noticed when dumping with "aapt" is that the flags of the string resource changed, with the extra "PUBLIC" attribute.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by connor.tumbleson on 2013-01-30T01:15:02.000Z:

Attach apk?

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by connor.tumbleson on 2013-01-30T01:15:02.000Z:

Attach apk?

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by Henry.Hu.SH on 2013-01-30T01:22:14.000Z:

Attached

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by Henry.Hu.SH on 2013-01-30T01:22:14.000Z:

Attached

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #3 originally posted by connor.tumbleson on 2013-01-30T01:28:24.000Z:

Yeah, ugh. I see the @string.

I don't know why Apktool is breaking that. Why don't developers use integers for that, or just not mess w/ strings for that versionName.

Owner

iBotPeaches commented Mar 18, 2015

Comment #3 originally posted by connor.tumbleson on 2013-01-30T01:28:24.000Z:

Yeah, ugh. I see the @string.

I don't know why Apktool is breaking that. Why don't developers use integers for that, or just not mess w/ strings for that versionName.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #4 originally posted by connor.tumbleson on 2013-03-04T12:41:03.000Z:

Issue 423 has been merged into this issue.

Owner

iBotPeaches commented Mar 18, 2015

Comment #4 originally posted by connor.tumbleson on 2013-03-04T12:41:03.000Z:

Issue 423 has been merged into this issue.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #5 originally posted by connor.tumbleson on 2013-03-21T11:31:37.000Z:

Will strip those 2 elements from Manifest, much like I do with other ones.

--version-code
inserts android:versionCode in to manifest.
--version-name
inserts android:versionName in to manifest.

Then use these on rebuild. Shouldn't be picky on whats correct.

Owner

iBotPeaches commented Mar 18, 2015

Comment #5 originally posted by connor.tumbleson on 2013-03-21T11:31:37.000Z:

Will strip those 2 elements from Manifest, much like I do with other ones.

--version-code
inserts android:versionCode in to manifest.
--version-name
inserts android:versionName in to manifest.

Then use these on rebuild. Shouldn't be picky on whats correct.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #6 originally posted by connor.tumbleson on 2013-03-21T13:58:06.000Z:

Fixed in wip2.0

Owner

iBotPeaches commented Mar 18, 2015

Comment #6 originally posted by connor.tumbleson on 2013-03-21T13:58:06.000Z:

Fixed in wip2.0

LoungeKatt pushed a commit to LoungeKatt/android-apktool that referenced this issue Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment