New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping declared attributes in AndroidManifest #580

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 469 created by jcase@cunninglogic.com on 2013-06-11T23:57:31.000Z:

What steps will reproduce the problem?

  1. Build application with minimum sdk declared in the manifest, but no target
  2. Decode application resources

What is the expected output? What do you see instead?

To see minimum sdk level in decoded Manifest

I see no sdk info

What version of the product are you using? On what operating system?
1.5.2, OSX Mountain Lion

Please provide any additional information below.
See attached poc apk

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by connor.tumbleson on 2013-06-12T03:03:55.000Z:

Stored in apktool.yml, and re-added during build.

This is because aapt requires parameters to set versionCode, instead of keeping it inside manifest.

Not a bug.

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by connor.tumbleson on 2013-06-12T03:03:55.000Z:

Stored in apktool.yml, and re-added during build.

This is because aapt requires parameters to set versionCode, instead of keeping it inside manifest.

Not a bug.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by jcase@cunninglogic.com on 2013-06-12T04:29:54.000Z:

Fine, will re-submit as a feature request, to keep Manifest as true to original form as possible (many people do not use APK to rebuild, just for analysis).

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by jcase@cunninglogic.com on 2013-06-12T04:29:54.000Z:

Fine, will re-submit as a feature request, to keep Manifest as true to original form as possible (many people do not use APK to rebuild, just for analysis).

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #3 originally posted by connor.tumbleson on 2013-06-12T13:00:23.000Z:

We can add it.

I think we have a -a parameter for [b]uild, for aapt, but I don't think we have an -a parameter for [d]ecode.

So it shouldn't be too hard to -a / --analysis, and skip all those checks that remove sdk info, version stuff.

Though, is it bad practice to have a parameter that means 2 different things depending on decoding / building.

Owner

iBotPeaches commented Mar 18, 2015

Comment #3 originally posted by connor.tumbleson on 2013-06-12T13:00:23.000Z:

We can add it.

I think we have a -a parameter for [b]uild, for aapt, but I don't think we have an -a parameter for [d]ecode.

So it shouldn't be too hard to -a / --analysis, and skip all those checks that remove sdk info, version stuff.

Though, is it bad practice to have a parameter that means 2 different things depending on decoding / building.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #4 originally posted by connor.tumbleson on 2013-06-12T15:05:17.000Z:

This issue was closed by revision 832978a.

Owner

iBotPeaches commented Mar 18, 2015

Comment #4 originally posted by connor.tumbleson on 2013-06-12T15:05:17.000Z:

This issue was closed by revision 832978a.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #5 originally posted by connor.tumbleson on 2013-06-12T15:06:12.000Z:

Fixed.

832978a

Needs more testing to be sure, I didn't break anything.

Owner

iBotPeaches commented Mar 18, 2015

Comment #5 originally posted by connor.tumbleson on 2013-06-12T15:06:12.000Z:

Fixed.

832978a

Needs more testing to be sure, I didn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment