New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apktool output is sent to stderr instead of stdout #620

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 510 created by mateorod9 on 2013-09-03T05:19:20.000Z:

What steps will reproduce the problem?

  1. Install framework files
  2. Capture stderr
  3. Examine stderr

What is the expected output? What do you see instead?
I would expect that line to be stdout

What version of the product are you using? On what operating system?
1.5.3.f3e50fbc56

Please provide any additional information below.

The apktool output is sent to stderr where I was expecting stdout. This creates an issue for certain batch or scripting situations. In my case, my script captures stderr and presents a failure message upon non-handled stderr...this causes a false positive.

I went through the apktool source for awhile, but did not see anything that was obvious to me. But I stopped short of finding out where you pull your output from the Logger to the screen.

Here is a very basic proof of issue script and output:

http://pastebin.com/0MSzyJ9v

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by connor.tumbleson on 2013-09-03T11:58:35.000Z:

I knew this was gonna be reported eventually.

Yes our logging system sucks and its hacky.

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by connor.tumbleson on 2013-09-03T11:58:35.000Z:

I knew this was gonna be reported eventually.

Yes our logging system sucks and its hacky.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by connor.tumbleson on 2013-09-07T13:55:40.000Z:

A good enough fix for now is just knock all errors properly to stderr.

be4ae92

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by connor.tumbleson on 2013-09-07T13:55:40.000Z:

A good enough fix for now is just knock all errors properly to stderr.

be4ae92

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #3 originally posted by mateorod9 on 2013-09-08T16:18:24.000Z:

I have redirected output to /dev/null in my use case, so I am having no trouble with this issue in any sense. But I thought I would mention that what I found was that stdout was being reported as stderr. The new changes are correctly categorizing your error messages, but I believe the issue still exists as reported. I have not built/tested with your new change, so forgive me if this fixes more than what I presume.

Thanks for all the hard work!

Owner

iBotPeaches commented Mar 18, 2015

Comment #3 originally posted by mateorod9 on 2013-09-08T16:18:24.000Z:

I have redirected output to /dev/null in my use case, so I am having no trouble with this issue in any sense. But I thought I would mention that what I found was that stdout was being reported as stderr. The new changes are correctly categorizing your error messages, but I believe the issue still exists as reported. I have not built/tested with your new change, so forgive me if this fixes more than what I presume.

Thanks for all the hard work!

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #4 originally posted by connor.tumbleson on 2013-09-08T16:20:14.000Z:

ahh, I misunderstood.

Owner

iBotPeaches commented Mar 18, 2015

Comment #4 originally posted by connor.tumbleson on 2013-09-08T16:20:14.000Z:

ahh, I misunderstood.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #5 originally posted by connor.tumbleson on 2013-09-14T17:38:51.000Z:

This should fix it :)

acd335f

Owner

iBotPeaches commented Mar 18, 2015

Comment #5 originally posted by connor.tumbleson on 2013-09-14T17:38:51.000Z:

This should fix it :)

acd335f

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #6 originally posted by mateorod9 on 2013-09-15T03:14:35.000Z:

Yep! Looks good.

Owner

iBotPeaches commented Mar 18, 2015

Comment #6 originally posted by mateorod9 on 2013-09-15T03:14:35.000Z:

Yep! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment