Uncompressed unknown files becomes compressed. #878

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 769 created by canab.ua on 2015-02-26T14:23:01.000Z:

What steps will reproduce the problem?

  1. decompile apk that contains assemblies/*.dll files
  2. build apk from decompiled sources
  3. unzip -vl new.apk

What is the expected output? What do you see instead?
...
950272 Stored 950272 0% 02-26-15 15:49 5559ccd7 assemblies/Mono.Android.dll
...

What version of the product are you using? On what operating system?
...
950272 Defl:N 242950 74% 02-26-15 15:53 5559ccd7 assemblies/Mono.Android.dll
...

Please provide any additional information below.
File was "Stored" in original apk and becomes "Defl:N".
It prevents apk from functioning at all.
dll files are treated as "Unknown"

From apktool.yml:

unknownFiles:
...
assemblies/Mono.Android.dll: '0'

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by connor.tumbleson on 2015-02-26T14:30:15.000Z:

I wondered when this would get reported. I log stored vs deflated as you can see via the apktool.yml, but its entirely ignored.

This was because of a bug or something that I can't remember with Java NIO.

I'll take another peek.

-- note to me
https://github.com/iBotPeaches/Apktool/blob/master/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java#L581

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by connor.tumbleson on 2015-02-26T14:30:15.000Z:

I wondered when this would get reported. I log stored vs deflated as you can see via the apktool.yml, but its entirely ignored.

This was because of a bug or something that I can't remember with Java NIO.

I'll take another peek.

-- note to me
https://github.com/iBotPeaches/Apktool/blob/master/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java#L581

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by canab.ua on 2015-02-26T14:56:10.000Z:

Additional info:

ApkTool version: 2.0.0 RC4

OS: Mac OSX 10.10

java version "1.7.0_45"
Java(TM) SE Runtime Environment (build 1.7.0_45-b18)
Java HotSpot(TM) 64-Bit Server VM (build 24.45-b08, mixed mode)

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by canab.ua on 2015-02-26T14:56:10.000Z:

Additional info:

ApkTool version: 2.0.0 RC4

OS: Mac OSX 10.10

java version "1.7.0_45"
Java(TM) SE Runtime Environment (build 1.7.0_45-b18)
Java HotSpot(TM) 64-Bit Server VM (build 24.45-b08, mixed mode)

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 29, 2015

Owner

9dc240c

Fixed via that.

Owner

iBotPeaches commented Mar 29, 2015

9dc240c

Fixed via that.

pwelyn added a commit to pwelyn/Apktool that referenced this issue Mar 30, 2015

Merge pull request #9 from iBotPeaches/master
[skip] update changelog to reflect fix of #878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment