Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
XML-Compiler feature missing - surpress overwriting platformBuildVersionName to "APKTOOL" #890
Original issue 781 created by TheHardyG on 2015-03-13T07:27:08.000Z:
What steps will reproduce the problem?
What is the expected output? What do you see instead?
What version of the product are you using? On what operating system?
Please provide any additional information below.
To be honest I only did that change because not touching it caused aapt to fail and my background in c++ wasn't strong enough to figure out the alternative of leaving the value if one is present or writing it if no value is present.
Then again on the flip side, platformBuildVersion is a value controlled by the build system not user. It'll change the value on stock aapt to the version it's at. This makes me think it should change it.
On the flip flip side I understand the importance of not watermarking apktool into apk. I'll try and rewrite that to only add if a value isn't present.