New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to force decoding of AndroidManifest.xml #1680

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@rubenanagua
Contributor

rubenanagua commented Dec 7, 2017

Forces decoding of AndroidManifest.xml, even if --no-res is set. This is useful for analysis of the manifest if resources aren't relevant, saving the step of decoding other resources, which account for a significant amount of time.

I have set it to be an advanced option, named --force-manifest (feel free to change this). As such:

  • Setting --force-manifest and not setting --no-res does not change the previous behavior of Apktool;
  • Setting --force-manifest and --no-res decodes AndroidManifest.xml, but not other resources.

If accepted, I can submit another pull request regarding gh-pages with documentation for this option.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Dec 7, 2017

Owner

Thanks for this. I am going to do a few tests and perhaps add a test suite to prevent regression and I'll get this merged.

Owner

iBotPeaches commented Dec 7, 2017

Thanks for this. I am going to do a few tests and perhaps add a test suite to prevent regression and I'll get this merged.

@iBotPeaches iBotPeaches self-assigned this Dec 7, 2017

@iBotPeaches iBotPeaches added this to the 2.3.1 milestone Dec 7, 2017

@iBotPeaches iBotPeaches merged commit 4158347 into iBotPeaches:master Dec 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Dec 7, 2017

Owner

Thanks again! Worked great and added a few tests to prevent regressions.

The docs repo needs a slight update for new parameters, but the local spin up of docs (or mine) is having some troubles. So no worries on updating docs. I'll get those added when I get docs working locally again.

Owner

iBotPeaches commented Dec 7, 2017

Thanks again! Worked great and added a few tests to prevent regressions.

The docs repo needs a slight update for new parameters, but the local spin up of docs (or mine) is having some troubles. So no worries on updating docs. I'll get those added when I get docs working locally again.

@iBotPeaches iBotPeaches removed the In Progress label Dec 7, 2017

iBotPeaches added a commit that referenced this pull request Dec 7, 2017

@0x454447415244

This comment has been minimized.

Show comment
Hide comment
@0x454447415244

0x454447415244 Sep 20, 2018

Is it possible to recompile if we set both flags --force-manifest and --no-res ? I tried it but it doesn't work. The manifest file will be considered as corrupted and the package won't install.

The thing is that I need to perform some changes to the manifest file without decompiling the resources (which is problematic most of the times), then rebuild the package.

It seems that the build feature does not recompile the manifest file when --no-res flag was used during unpack. The manifest file will be in ascii form after recompile.

Any solution? Thanks.

0x454447415244 commented Sep 20, 2018

Is it possible to recompile if we set both flags --force-manifest and --no-res ? I tried it but it doesn't work. The manifest file will be considered as corrupted and the package won't install.

The thing is that I need to perform some changes to the manifest file without decompiling the resources (which is problematic most of the times), then rebuild the package.

It seems that the build feature does not recompile the manifest file when --no-res flag was used during unpack. The manifest file will be in ascii form after recompile.

Any solution? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment