Join GitHub today
Patch APKTool to allow repeated entry offsets to appear #1683
Hello! I'm sending this pull request on behalf of Facebook. We've been using a slightly modified APKTool internally- it would be great to get the changes incorporated back into this main open source repository.
There are two main changes:
Example beta build (version 153) of Facebook for Android which requires the 'repeated offsets' fix: https://www.dropbox.com/s/1n3dx7xhelxtik9/fb4a.153-beta.apk?dl=0
Attempting to decode this APK without the fix results in this error:
java -jar ./brut.apktool/apktool-cli/build/libs/apktool-cli-all.jar d -f -o /example_out_dir /path/to/fb4a.153-beta.apk
The program executes correctly with the fix applied.
Hi there. Thanks for sending things back upstream!
About 17 hours ago, we actually just merged a change into master for decoding just the manifest, if required. This can be seen here: 5734c68
Documentation hasn't been updated yet, but the idea is
Otherwise looking through the code, I see plenty of good fixes all around, so thanks again for sending them upstream. I'll pull it down and get this merged after I resolve the duplicate parameters for decoding just manifest.
Good point, it does look like we can use that new addition instead. When combined with '--no-src' it's almost as fast as --manifest-only. Time comparisons:
--manifest-only : 7.8 seconds
All three options produce the files we need (AndroidManifest and the meta yaml file). It's no big deal that additional files are produced that we don't need, and options 1 and 2 are roughly as fast as each other, so I'm fine with the suggestion of getting rid of the new parameter to keep things simpler.
Thanks for the speedy response!