New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X ~/Library change #49

Merged
merged 1 commit into from Oct 11, 2012

Conversation

Projects
None yet
3 participants
@kckrinke
Contributor

kckrinke commented Oct 11, 2012

...esolution is to change the ~/Library/Application Support/apktool path to ~/Library/apktool. Fix is for OS X only. Do not think there is problems on other platforms with this.

Runtime.exec has problems dealing with spaces in arguments given. Lam…
…e resolution is to change the ~/Library/Application Support/apktool path to ~/Library/apktool. Fix is for OS X only. Do not think there is problems on other platforms with this.

iBotPeaches added a commit that referenced this pull request Oct 11, 2012

@iBotPeaches iBotPeaches merged commit 09d834b into iBotPeaches:master Oct 11, 2012

@BurgerZ

This comment has been minimized.

Contributor

BurgerZ commented on 17f715f Oct 11, 2012

Runtime.exec can handle spaces.

  1. Process p = Runtime.getRuntime().exec(String[] {"/path with spaces in it/binaryToRun"});
  2. Or specifying the title for the starting command (if we have spaces in path)
    String fileName = "c:\My Folder Name With Spaces\test.doc";
    String[] commands = {"cmd", "/c", "start", ""Title"",fileName};
    Runtime.getRuntime().exec(commands);

This comment has been minimized.

Contributor

kckrinke replied Oct 11, 2012

My bad. Looking a little deeper and it's actually aapt that can't handle the spaces.
aapt dump badging ~/Library/Application\ Support/apktool/framework/1.apk W/asset ( 4946): Asset path /Users/onest8/Library/Application is neither a directory nor file (type=1).

(Yes I know you can't dump badging on 1.apk but the above is just to illustrate the failure.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment