From 7b3cba56384e4535a23f3d3f64a6e2a9660fe4c3 Mon Sep 17 00:00:00 2001 From: Gabriel Fournier Date: Mon, 16 Dec 2024 19:08:35 +0100 Subject: [PATCH 1/3] use already compute var group --- contracts/modules/delegates/IexecPoco2Delegate.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/modules/delegates/IexecPoco2Delegate.sol b/contracts/modules/delegates/IexecPoco2Delegate.sol index 33aeecec4..fe74c7312 100644 --- a/contracts/modules/delegates/IexecPoco2Delegate.sol +++ b/contracts/modules/delegates/IexecPoco2Delegate.sol @@ -161,7 +161,7 @@ contract IexecPoco2Delegate is IexecPoco2, DelegateBase, IexecEscrow, SignatureV uint256 delta = Math.max(group, 1) * weight - group; contribution.weight = Math.log2(weight); - consensus.group[_resultHash] = consensus.group[_resultHash] + delta; + consensus.group[_resultHash] = group + delta; consensus.total = consensus.total + delta; // Check consensus From 37e229a9b0c046f960844e2bb8373c208e7d8463 Mon Sep 17 00:00:00 2001 From: Gabriel Fournier Date: Tue, 17 Dec 2024 09:06:58 +0100 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7be7bcede..496a3ae79 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,12 @@ # Changelog ## vNEXT + +### Updated contracts +- [x] `IexecPoco2Delegate.sol` + +### Features +- Remove reused code in `IexecPoco2Delegate` in `contribute(...)` function. (#168) - Remove references to blockscout v5. (#161) - Migrate integration test files to Typescript & Hardhat: - 000_fullchain.js (#156, #157) From 3cd2e224236dc269a24857f482d181d69542e11f Mon Sep 17 00:00:00 2001 From: gfournieriExec <100280020+gfournieriExec@users.noreply.github.com> Date: Wed, 18 Dec 2024 14:19:15 +0100 Subject: [PATCH 3/3] Update CHANGELOG.md Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d5870ab1b..440e61ca7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ - [x] `IexecPoco2Delegate.sol` ### Features -- Remove reused code in `IexecPoco2Delegate` in `contribute(...)` function. (#168) +- Re-use variable in `IexecPoco2Delegate` in `contribute(...)` function. (#168) - Remove unnecessary back and forth transfers in `IexecPoco2Delegate` happening during `claim(..)`. (#167) - Remove references to blockscout v5. (#161) - Migrate integration test files to Typescript & Hardhat: