Permalink
Commits on Mar 29, 2017
  1. Merge pull request #267 from iFixit/dozuki-saml-login-fix

    timothyasp committed on GitHub Mar 29, 2017
    Fix SAML login error
Commits on Mar 28, 2017
  1. Fix SAML login error

    timothyasp committed Mar 28, 2017
    SAML login for most customers was broken.
    
    The WebView logic that checks for the session cookies returned by the Clients
    login form was tricked into thinking that it was on the dozuki domain, when
    really it was still on the SAML login page. This is because we use a "Black
    List" when deciding if we shouldn't capture and return the cookies. That black
    list was capturing some false positives due to query params in SAML urls that
    include the dozuki hostname.
    
    The solution was to make the regex/string-comparison stricter to only look at
    the first part of the domain, rather than anywhere in the URL string.
Commits on Feb 20, 2016
Commits on Feb 18, 2016
  1. It's 2016

    timothyasp committed Feb 18, 2016
  2. Bump version numbers

    timothyasp committed Feb 18, 2016
  3. Merge pull request #260 from iFixit/fix-html-injection

    timothyasp committed Feb 18, 2016
    Fix html injection
  4. Bump version # for release

    timothyasp committed Feb 18, 2016
  5. Remove `HTML.fromHtml` wrappers around guide titles

    timothyasp committed Feb 18, 2016
    Guide titles will never be HTML, so I have no idea why we were wrapping them in
    these calls.  I tested what it looks like after removing the fromHtml wrapper,
    and nothing changed, except we don't have a phishing vulnerability anymore,
    so I think we're good.
    
    Closes #259
Commits on Sep 15, 2015
  1. Merge pull request #256 from iFixit/gradle-properties-base--add-missi…

    marczych committed Sep 15, 2015
    …ng-properties
    
    gradle.properties.base: Add missing properties
  2. gradle.properties.base: Add missing properties

    marczych committed Sep 15, 2015
    This adds the missing properties to `gradle.properties.base` so the app
    can be built when it is copied to `gradle.properties`.
    
    Closes #255
Commits on Aug 13, 2015
Commits on Jul 27, 2015
  1. Merge pull request #254 from iFixit/oscaro-custom-app

    timothyasp committed Jul 27, 2015
    Oscaro custom app
Commits on Jul 24, 2015
Commits on Jul 6, 2015
  1. Merge update-strings-for-crowdin (#253) into master

    marczych committed Jul 6, 2015
    Update strings found by crowdin
    
    This updates two strings that people at crowdin had issues with. One had
    a simple typo, the other needed a better description for it.
Commits on Jul 5, 2015
  1. Update strings found by crowdin

    andrewjpiro committed Jul 5, 2015
    This updates two strings that people at crowdin had issues with. One had
    a simple typo, the other needed a better description for it.
Commits on Jun 9, 2015
  1. Merge pull request #252 from iFixit/pva-custom-app

    timothyasp committed Jun 9, 2015
    Add custom PVA dozuki app
Commits on Jun 3, 2015
  1. Add custom PVA dozuki app

    timothyasp committed Jun 3, 2015
Commits on May 12, 2015
  1. Merge google-login--dont-always-initialize into master

    marczych committed May 12, 2015
    Google login: Don't always initialize API client
    
    We don't always want to initialize the GoogleApiClient because we have
    to do a white label app specifically for that site to make it happen.
    For now iFixit is the only site that has this set up.
  2. Google login: Don't always initialize API client

    marczych committed May 12, 2015
    We don't always want to initialize the GoogleApiClient because we have
    to do a white label app specifically for that site to make it happen.
    For now iFixit is the only site that has this set up.
  3. Merge intent-filters--force-new-task (#251) into master

    marczych committed May 12, 2015
    IntentFilterActivity: Force new task
    
    In order to make the back button behave properly when coming from search
    results or other intents, we must force `IntentFilterActivity` to have a
    different `taskAffinity` so it doesn't launch the activities into the
    same stack as the main application. This results in an empty back stack
    for all Activities routed through `IntentFilterActivity` which is
    exactly what we want.
  4. IntentFilterActivity: Force new task

    marczych committed May 12, 2015
    In order to make the back button behave properly when coming from search
    results or other intents, we must force `IntentFilterActivity` to have a
    different `taskAffinity` so it doesn't launch the activities into the
    same stack as the main application. This results in an empty back stack
    for all Activities routed through `IntentFilterActivity` which is
    exactly what we want.
Commits on May 7, 2015
  1. Merge google-oauth-login (#250) into master

    marczych committed May 7, 2015
    Google Login: Migrate to OAuth
    
    Google login through OpenID has been deprecated for a little while now so
    we have to migrate to Google OAuth. This results in a much better user
    experience because it goes through the native interface and doesn't require
    the user to enter their credentials.
    
    This also increases the `minSdkVersion` to `9` which is android 2.3. This is
    required for Google Play Services which provides the Google Login
    functionality. Android 2.2 only makes up 0.65% of installs currently. It's
    unfortunate to lose them but the old app will still work for them.
    
    QA
    ==
    
     - Check Google login on a few places that require it:
       - Media manager
       - Favorite guides
       - Favoriting a guide
       - etc.
     - Test on various devices:
       - Android 2.3
       - Android 5+
       - Tablet
       - Phone
     - Test in both orientations:
       - Portrait
       - Landscape
     - Unexpected actions:
       - Decline permissions
       - Cancel dialogs
       - Change orientations
     - Test on various accounts:
       - No associated iFixit account
       - iFixit account with permissions accepted through the web signin
       - iFixit account after prior sign in on Android
    
    Closes #249
  2. Build tools: Minor downgrade

    marczych committed May 7, 2015
    There appears to be a bug with the latest build tools that causes
    crashes on Android 2.3. 21.1.2 gets us the tools we need to handle the
    play services proguard bug but doesn't get us the broken 2.3 bug.
    
    See: http://stackoverflow.com/q/29856263/1135611
Commits on May 6, 2015
  1. Bump version to 2.9.0

    marczych committed May 1, 2015
  2. Google login: Fix broken account chooser

    marczych committed May 1, 2015
    This makes it so the login process continues after the user selects
    which account to use if ever.
Commits on May 1, 2015
  1. Google login: Display progress spinner on login

    marczych committed May 1, 2015
    Otherwise it's not clear what's going on.
  2. Google login: Allow logging in after prior cancel

    marczych committed May 1, 2015
    Without this clicking the Google login button after declining the
    permissions wouldn't do anything. Now it reconnects and prompts you to
    authorize the permissions.
  3. Play services: Don't include entire library

    marczych committed May 1, 2015
    Might as well just include the few APIs we use rather than the entire
    monstrosity that is Google Play Services.
  4. Google login: Disable for Dozuki

    marczych committed May 1, 2015
    It won't work because of the limitations given the app's package name
    and the server's project setup.
  5. Google login: Invalidate token after retrieval

    marczych committed Apr 30, 2015
    We can only use it once so we need to invalidate it from the local cache
    to avoid getting the same one next time which would then be invalid.