Permalink
Commits on Sep 15, 2015
  1. @marczych

    Merge pull request #256 from iFixit/gradle-properties-base--add-missi…

    …ng-properties
    
    gradle.properties.base: Add missing properties
    marczych committed Sep 15, 2015
  2. @marczych

    gradle.properties.base: Add missing properties

    This adds the missing properties to `gradle.properties.base` so the app
    can be built when it is copied to `gradle.properties`.
    
    Closes #255
    marczych committed Sep 15, 2015
Commits on Jul 6, 2015
  1. @marczych

    Merge update-strings-for-crowdin (#253) into master

    Update strings found by crowdin
    
    This updates two strings that people at crowdin had issues with. One had
    a simple typo, the other needed a better description for it.
    marczych committed Jul 6, 2015
Commits on May 12, 2015
  1. @marczych

    Merge google-login--dont-always-initialize into master

    Google login: Don't always initialize API client
    
    We don't always want to initialize the GoogleApiClient because we have
    to do a white label app specifically for that site to make it happen.
    For now iFixit is the only site that has this set up.
    marczych committed May 12, 2015
  2. @marczych

    Google login: Don't always initialize API client

    We don't always want to initialize the GoogleApiClient because we have
    to do a white label app specifically for that site to make it happen.
    For now iFixit is the only site that has this set up.
    marczych committed May 12, 2015
  3. @marczych

    Merge intent-filters--force-new-task (#251) into master

    IntentFilterActivity: Force new task
    
    In order to make the back button behave properly when coming from search
    results or other intents, we must force `IntentFilterActivity` to have a
    different `taskAffinity` so it doesn't launch the activities into the
    same stack as the main application. This results in an empty back stack
    for all Activities routed through `IntentFilterActivity` which is
    exactly what we want.
    marczych committed May 12, 2015
  4. @marczych

    IntentFilterActivity: Force new task

    In order to make the back button behave properly when coming from search
    results or other intents, we must force `IntentFilterActivity` to have a
    different `taskAffinity` so it doesn't launch the activities into the
    same stack as the main application. This results in an empty back stack
    for all Activities routed through `IntentFilterActivity` which is
    exactly what we want.
    marczych committed May 12, 2015
Commits on May 7, 2015
  1. @marczych

    Merge google-oauth-login (#250) into master

    Google Login: Migrate to OAuth
    
    Google login through OpenID has been deprecated for a little while now so
    we have to migrate to Google OAuth. This results in a much better user
    experience because it goes through the native interface and doesn't require
    the user to enter their credentials.
    
    This also increases the `minSdkVersion` to `9` which is android 2.3. This is
    required for Google Play Services which provides the Google Login
    functionality. Android 2.2 only makes up 0.65% of installs currently. It's
    unfortunate to lose them but the old app will still work for them.
    
    QA
    ==
    
     - Check Google login on a few places that require it:
       - Media manager
       - Favorite guides
       - Favoriting a guide
       - etc.
     - Test on various devices:
       - Android 2.3
       - Android 5+
       - Tablet
       - Phone
     - Test in both orientations:
       - Portrait
       - Landscape
     - Unexpected actions:
       - Decline permissions
       - Cancel dialogs
       - Change orientations
     - Test on various accounts:
       - No associated iFixit account
       - iFixit account with permissions accepted through the web signin
       - iFixit account after prior sign in on Android
    
    Closes #249
    marczych committed May 7, 2015
  2. @marczych

    Build tools: Minor downgrade

    There appears to be a bug with the latest build tools that causes
    crashes on Android 2.3. 21.1.2 gets us the tools we need to handle the
    play services proguard bug but doesn't get us the broken 2.3 bug.
    
    See: http://stackoverflow.com/q/29856263/1135611
    marczych committed May 7, 2015
Commits on May 6, 2015
  1. @marczych

    Bump version to 2.9.0

    marczych committed May 1, 2015
  2. @marczych

    Google login: Fix broken account chooser

    This makes it so the login process continues after the user selects
    which account to use if ever.
    marczych committed May 1, 2015
  3. @marczych
Commits on May 1, 2015
  1. @marczych

    Google login: Display progress spinner on login

    Otherwise it's not clear what's going on.
    marczych committed May 1, 2015
  2. @marczych

    Google login: Allow logging in after prior cancel

    Without this clicking the Google login button after declining the
    permissions wouldn't do anything. Now it reconnects and prompts you to
    authorize the permissions.
    marczych committed May 1, 2015
  3. @marczych
  4. @marczych

    Play services: Don't include entire library

    Might as well just include the few APIs we use rather than the entire
    monstrosity that is Google Play Services.
    marczych committed May 1, 2015
  5. @marczych

    Google login: Disable for Dozuki

    It won't work because of the limitations given the app's package name
    and the server's project setup.
    marczych committed May 1, 2015
  6. @marczych
  7. @marczych

    Google login: Invalidate token after retrieval

    We can only use it once so we need to invalidate it from the local cache
    to avoid getting the same one next time which would then be invalid.
    marczych committed Apr 30, 2015
  8. @marczych
  9. @marczych
  10. @marczych

    Google login: Basic building blocks

    This adds the play services dependency and uses it in the login fragment
    to natively prompt for google login.
    marczych committed Apr 28, 2015
  11. @marczych

    Add Gradle Wrapper

    I'm not crazy about committing these files but it makes it easier to get
    the development environment setup.
    marczych committed Apr 28, 2015
Commits on Jan 5, 2015
  1. @marczych

    Gradle properties base: Add magnoliamedical

    We added Magnolia Medical as a white labelled app in #239 but didn't add
    the default values in `gradle.properties.base` so users can't build the
    app without adding the necessary values.
    marczych committed Jan 5, 2015
Commits on Dec 1, 2014
  1. @marczych
Commits on Nov 17, 2014
  1. @marczych

    Intent filtering: Respond to /Device/name

    We already had the code for it in `IntentFilterActivity` but we didn't
    have the manifest set up to register the filter.
    marczych committed Nov 17, 2014
Commits on Nov 4, 2014
  1. @marczych

    Step bullets: Add light blue

    Fixes #233.
    
    This adds a light blue bullet to step view and step edit and does a few
    other things along the way:
    
     - Replace all bullet color image drawables with shape drawables so we
       don't have 2 sets of images that don't match and are hard to update.
     - Remove some unused drawables (there were dark and light copies of a
       few of them but only one version was ever used).
     - Standardize on violet rather than having it split between violet,
       purple, and pink.
    marczych committed Nov 4, 2014
Commits on Sep 30, 2014
  1. @marczych

    GuideViewActivity: Use notOnStep in menu click

    Also remove `this.` from the places where it isn't required.
    marczych committed Sep 30, 2014
Commits on Aug 28, 2014
  1. @marczych

    Guide completions: Consolidate ApiEvents

    UncompleteGuide wasn't ever used so I decided to remove it.
    Additionally, I changed CompleteGuide to be an ApiEvent<Boolean> so it
    will work for uncompleting guides just like FavoriteGuide does.
    marczych committed Aug 28, 2014
  2. @marczych

    Guide completions: Use Api.getErrorDialog

    It displays an appropriate error to the user and handles expired
    sessions, retries, etc.
    marczych committed Aug 28, 2014
  3. @marczych

    ApiEndpoint: Fix indentation

    marczych committed Aug 28, 2014
  4. @marczych

    Guide view: Fix edit on parts and tools

    Any non-step page sould take you to edit guide details. This wasn't the
    case for parts and tools which took you to edit the first step.
    marczych committed Aug 28, 2014
  5. @marczych
Commits on Aug 18, 2014
  1. @marczych
  2. @marczych

    Build tools: Upgrade to 0.12.2

    This also changes `packageName` to `applicationId` per these
    instructions:
    
    http://tools.android.com/tech-docs/new-build-system/applicationid-vs-packagename
    marczych committed Aug 18, 2014