Skip to content
This repository has been archived by the owner. It is now read-only.

iPhone X/Xs/11 - Start/Select buttons hard to hit #55

Open
JanJastrow opened this issue Nov 19, 2019 · 3 comments
Open

iPhone X/Xs/11 - Start/Select buttons hard to hit #55

JanJastrow opened this issue Nov 19, 2019 · 3 comments

Comments

@JanJastrow
Copy link

@JanJastrow JanJastrow commented Nov 19, 2019

Description

I'm using Eclipse as an PWA fullscreen app on my iPhone Xs and I have a lot of problems tapping the "Start" and "Select" buttons while playing.
These buttons are at the very bottom of the screen, where on the newer iPhones the "home indicator" is located.
This means that iOS thinks you want to tap the "home button" instead of the buttons that are very close to it.
I hit the buttons 10-20 times and sometimes I'm able to hit their (very small) remaining hitbox and trigger them.

Can we get a bottom margin of a few pixels for the buttons on iOS PWA?

How to Reproduce

Use the PWA on a modern iOS device

Device Information

iPhone Xs
iOS 13.2.3

@JanJastrow JanJastrow changed the title iPhone X/Xs/11 - Hard to hit buttons iPhone X/Xs/11 - Start/Select buttons hard to hit Nov 20, 2019
@glennfu
Copy link

@glennfu glennfu commented Nov 26, 2019

I don't have access to the repo (would love to contribute) but it seems like after a quick inspect, this would do the trick:

.emu-controls .start-select button {
    padding-top: 5px;
    padding-bottom: 5px;
}

@magnetardev
Copy link
Contributor

@magnetardev magnetardev commented Apr 24, 2020

Would you mind testing this out and seeing if it works? This is what we’ll be using in v3, so if it works then that’ll be one common issue off our list. Thanks. (Also we pushed a potential fix a few months ago, but want to tie up all our loose ends!)

https://zenithdevs.github.io/ControllerKit/demo/

@JanJastrow
Copy link
Author

@JanJastrow JanJastrow commented Apr 24, 2020

Hi, thank you for your answer.
I have tried it and it seems to be working very good. No missed clicked as a PWA. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants