New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a helper to set the name of the MCParticle collection #153
Conversation
DDSim/DDSim/Helper/MCParticles.py
Outdated
Default is "MCParticle". | ||
""" | ||
return self._parameters["MCParticleCollectionName"] | ||
@particlesPerEvent.setter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be renamed as well.
Related to AIDASoft/DD4hep#147 You need to add the corresponding calls for your addition: Like what is done for GuineaPig in DD4hepSimulation Also please rename the |
Adding the helper to allow reading an MCParticle collection with an arbitrary name
DDSim/DDSim/Helper/LCIO.py
Outdated
|
||
from DDSim.Helper.Input import Input | ||
|
||
class MCParticles( Input ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't clear, the class should also be called LCIO.
Then you get the "--LCIO.mcParticleCollectionName" command line flag and option named "LCIO...." in the steering file.
Conceivably we get more options for lcio files at some point.
DDSim/DDSim/Helper/LCIO.py
Outdated
Default is "MCParticle". | ||
""" | ||
return self._parameters["MCParticleCollectionName"] | ||
@particlesPerEvent.setter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be renamed for the mcParticleCollectionName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what's still missing. Does this diff address your comment?
@jstrube are still working on addressing the issues ? Would be very useful to have in ... |
I thought this is done now. What's still missing? Did I not address Andre's suggestions? |
Sorry, I didn't get what the problem was. I think this is fixed now. |
@jstrube I have added release notes for you. Please do not remove the BEGINRELEASENOTES/ENDRELEASENOTES tags but rather fill in what you changed in future PRs |
I thought that's what I did in the first comment in this thread? |
Following guidelines laid out by @andresailer, I'm attempting to add a helper to allow setting the name of the MCParticle collection to something other than "MCParticle".
BEGINRELEASENOTES
- using parameter 'mcParticleCollectionName'
ENDRELEASENOTES