New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary bugfix for AwningValance (until this is fixed serverside) #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment with the qualified name asking us to this remove this trick once DeploymentState returned by the AwningValance?
] | ||
|
||
entities += [ | ||
VerticalCover(device.deviceurl, coordinator) | ||
for device in data["platforms"].get(COVER) | ||
if device.ui_class != "Awning" | ||
if device.ui_class != "Awning" or device.widget == "AwningValance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will have a reverse position issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been confirmed by 2 users that it now works like a charm. They had the reverse position issue with the Awning
.
commit 9505d8c Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Tue Aug 10 02:03:19 2021 -0700 Add sensors dynamically based on available device state (#425) * Add temporary state sensor * Add extra sensors * Add more states * Add more sensors * Create supported_platforms variable * Use Overkiz label as device name * Suffix state sensor name with device index * Avoid to duplicate state key * Remove now usless rssi level attribute * Migrate LightSensor to TahomaStateSensor * Apply linters * Add PriorityLockOriginatorState sensor * Bump minimum version to 2021.8 * Remove unneeded value key * Migrate to SensorEntityDescription * Small tweaks * Add battery level * Remove unused state keys * Test electricity sensor * Add extra sensors * Add sensor * Add all sensors from sensor.py * Add smoke text sensor * Make optional * Change all sensor to new structure * Improve sensor definitions * Ease state * Ease retrieve of the index * Rollback device_state_attributes * Revert battery changes * Remove const * Add LightSensor * Rollback icon logic in cover * Bugfixes * Add round for RSSI value Co-authored-by: Thibaut Etienne <thibaut@etienne.pw> commit e7a4554 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Tue Aug 10 01:56:39 2021 -0700 Add binary sensors dynamically based on available device state (#505) * Refactor binary sensor * Make import relative * Style fix * Update custom_components/tahoma/__init__.py Co-authored-by: Thibaut <thibaut@etienne.pw> * Add extra binary sensors * Clean for final PR * Feedback applied Co-authored-by: Thibaut <thibaut@etienne.pw> commit da5b26e Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Tue Aug 10 01:34:16 2021 -0700 Temporary bugfix for AwningValance (until this is fixed serverside) (#511) * Temporary bugfix for #486 * Add note
Fixes #510
Fixes #486