Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 RC2 Intermittent SBUS connection on Matek F405-STD and RadioLink R9DS #3563

Closed
Andreas-Hellberg opened this issue Jul 11, 2018 · 27 comments

Comments

Projects
None yet
8 participants
@Andreas-Hellberg
Copy link
Contributor

commented Jul 11, 2018

Board and Version

Matek F405-STD BetaFlight STM32F405 Flight Controller
https://www.banggood.com/Matek-F405-OSD-BetaFlight-STM32F405-Flight-Controller-Built-in-OSD-Inverter-for-RC-Multirotor-FPV-Racing-Drone-p-1141282.html?rmmds=search
v2.0.0 RC2
INAV/MATEKF405 2.0.0 Jun 29 2018 / 12:30:25 (a8415e8)

Behavior

When I tested upgrading to INAV 2.0 RC2 the SBUS connection became intermittent.
The board will read the stick positions for 0.5-1s then there will be a period of no changes for 1-2s then it reads the current RC input for 0.5s-1s and repeat. It's the same result when connected via USB and disconnected.

The same hardware works just fine on all previous versions of INAV I have tested (1.9.3, 1.9.0, etc).
I flashed the board with the "full chip erase" option set to true. I tested going back an forth between 1.9 and 2.0 multiple times. On 1.9 it works just fine, but not on 2.0.

Blackbox logs/Config (.ZIP) where problem occurs

https://pastebin.com/Sypn6ReH

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2018

Perhaps the receiver isn't respecting SBUS timings.
Can you set debug to SBUSand check what happening on the configurator Sensors tab in the debug data?

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

debug_mode set to SBUS:
sbus_debug

How it looks in the receiver tab:
sbus_intermittent

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2018

Seems like the DESYNC_COUNTER increases... then it is an issue the the receiver not respecting SBUS specifications.

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

Might be, but the receiver works fine in the previous releases with the old SBUS driver.

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2018

Older INAV versions were much more relaxed about SBUS input.
In 2.0 we have introduced a more strict approach when decoding SBUS packet to be sure that all the data is decoded correctly and no channels have invalid data.

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

To me this is a regression rather than an improvement. But hey I'm a bit biased as this stops me from upgrading.. :) I know I could create my own release and just revert the SBUS commits. Might do that in the future if this issue is closed without an resolution. But it could be that the new SBUS driver excludes more than just RadioLink receivers and that would be less than ideal if so.

@digitalentity

This comment has been minimized.

Copy link
Member

commented Jul 11, 2018

None of the devs has a RadioLink system, so troubleshooting this might be problematic.

@digitalentity

This comment has been minimized.

Copy link
Member

commented Jul 11, 2018

@giacomo892 @fiam I suggest to add this to known issues section and look into it after 2.0 release.

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2018

Added to wiki @digitalentity

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

I tested reverting PR 3110 (https://github.com/iNavFlight/inav/pull/3110/commits) and built + flashed it.
That worked so that will have to be my workaround for the time being.

sbus_fix

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2018

@Andreas-Hellberg bare in mind you may encounter mid air disarms and any other nasty things.

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2018

@giacomo892 I don't see why. As the SBUS code is the same in earlier versions of Inav. But even if you are right I think my frequent crashing tells me that potential software bugs is the least of my problems. :)

I'll probably have to replace my old RadioLink radio with a FrSky sooner rather than later. But my RadioLink gear have worked fine with, Cleanflight, Betaflight, all previos version of Inav and propitiatory software/hardware from DJI and Tarot. So I still think there is something wrong with the new SBUS driver.

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2018

@Andreas-Hellberg give a shot to RC4 and ply with the sync delay until you see no sync issues on debug data.

@digitalentity digitalentity added this to the 2.1 milestone Jul 15, 2018

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2018

@giacomo892 thanks for the reply, I tried changing the SBUS delay from 500,1500,2500 etc up to 10000. Did not see a significant improvement though. The min/max range for the new settings is reversed so I had to fix that before I could test it out.

image

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2018

@Andreas-Hellberg could you PR the fix?

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2018

@giacomo892 I tired but I get 403 Access denied when I try and push a branch.

@giacomo892

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2018

You need to Fork, commit to your branch and then PR to inav :)

@fiam

This comment has been minimized.

Copy link
Member

commented Jul 15, 2018

@Andreas-Hellberg do you have an oscilloscope to see the frequency of the SBUS signal output by that RX?

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2018

@giacomo892 thanks for the help. The tiny PR is now up at #3606 :)
@fiam No I don't have access to a oscilloscope. Any way to log the output via a FC?

fiam added a commit that referenced this issue Jul 15, 2018

When encoding settings, validate that min <= max for all settings
This will help catch errors like the one fixed in #3563 early.
@gppsoft

This comment has been minimized.

Copy link

commented Jul 16, 2018

Hello. I have this issue with 1.9.1 and Omnibus F4 Pro V2 + R9DS. Freezes when board connected via USB and battery plugged.

@Andreas-Hellberg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2018

@gppsoft is it just on 1.9.1 or is it all versions? It's a common issue if you have some external component (gps?) connected to the same UART (TX1/RX1) as the USB port. Then that component will go active once the battery is plugged in an interfere with the USB connection.

@rollanc

This comment has been minimized.

Copy link

commented Jul 20, 2018

Tested inav 2.0 rc4 with radiolink receiver R12DS, bus F4 v3, and sbus does not work for auxiliary channels.

@digitalentity

This comment has been minimized.

Copy link
Member

commented Jul 22, 2018

@rollanc if it works for main channels, but doesn't for AUX - it's likely a radio setup or messed up configuration issue.

@rollanc

This comment has been minimized.

Copy link

commented Jul 23, 2018

No, I have everything perfectly configured, I've already come from Inav 1.6. It must be error in the radiolink ibus frame, why fryski, if that works.

@happyvalley-lmx

This comment has been minimized.

Copy link

commented Oct 12, 2018

I'm also using RadioLink R9DS.
Sbus seems work fine on my omnibus F4V3.

@JVN2000

This comment has been minimized.

Copy link

commented Nov 11, 2018

I am using Radioink R9DS on a OMNIBUS F4PRO V2 and OMNIBUS F3 running inav 2.0, no problems at all.

@digitalentity

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

Seems this issue is not relevant anymore. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.