Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`diff` doesn't output differences in battery profile 2 & 3 #4827

Closed
teckel12 opened this issue Jun 11, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@teckel12
Copy link
Contributor

commented Jun 11, 2019

Current Behavior

diff doesn't list battery profile 2 & 3 changes

Steps to Reproduce

  1. Change battery profile 2 & 3
  2. save
  3. diff
  4. Doesn't list changes to battery profile 2 & 3

Expected behavior

diff should list all changes to defaults, unless I'm mistaken. I didn't check to see if profile changes were being listed with diff.

  • MATEKF722SE
  • 2.2.0-RC2
@issue-label-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Issue-Label Bot is automatically applying the label BUG to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the BUG label Jun 11, 2019

@shellixyz

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

You need to use diff all if you want the diff to include all profiles and battery profiles

@shellixyz shellixyz added Support and removed BUG labels Jun 11, 2019

@teckel12

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Perfect! diff all from now on.

@teckel12 teckel12 closed this Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.