Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity check for nav_wp_safe_distance should be only performed when activating the WP Mission, not when arming #4832

Open
peteoz opened this issue Jun 12, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@peteoz
Copy link

commented Jun 12, 2019

Current Behavior

when more than 650m (max value allowed) away from my 1st WP, I'm unable to arm, not sure if this is desirable behaviour because I may even decide not to fly the mission, and I want to be able to arm.

Desired Behavior

sanity check for nav_wp_safe_distance should be only performed when activating the WP Mission, meaning once in the air, then and only then when I flip my switch to activate the WP Mission should the sanity check be performed and simply not execute the mission if my model is more than nav_wp_safe_distance away from 1st WP

Suggested Solution

allow to arm the model regardless of the 1st WP distance from the launch site, because it is not necessary to do the sanity/safety check unless the pilot decides to activate the mission once in the air. pilot may even decide not to activate the mission.
secondly the safety distance check could ideally be measured between current position of the model and 1st WP (regardless of where the launch site is).
ex. if my nav_wp_safe_distance is 500m and my 1st WP is 2km North of my launch site, I could fly manually 1.5km North (to place my model 500m within reach of 1st WP) and then activate the mission, the mission should execute. however if my model was more than 500m away from 1st WP then the mission would not execute.

I also suggest to increase the maximum allowed value for nav_wp_safe_distance, currently 650m is way too restrictive and I found myself in situation where I could not arm and I could not relocate closer because the terrain did not allow me to.
more reasonable value would be something within reasonable range of our radio and video signal, for example 2-4km

Who does this impact? Who is this for?

for pilots flying in unknown terrain, unknown location, for example in remote desert area. in these locations the mission planning is difficult because there is no internet. I plan the missions days ahead with no final knowledge of the terrain and not knowing local conditions, sometimes I find myself only 1km away from my intended launch site but I cannot get there due to terrain restriction, in this case I cannot arm my model.

Additional context

there is no sanity check (restriction) when creating 2nd WP, it can be many kilometers away from 1st WP, so why is there such a severe restriction on 1st WP ?

when I forget to load my mission from EEPROM before arming and then try to execute mission once in the air, nothing happens because I'm trying to execute invalid mission.
in exactly same way should the sanity check for nav_wp_safe_distance be performed, only once in the air and only once the pilot tries to activate WP Mission, if the 1st WP is invalid then don't execute the mission.

@issue-label-bot issue-label-bot bot added the BUG label Jun 12, 2019

@issue-label-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

Issue-Label Bot is automatically applying the label BUG to this issue, with a confidence of 0.60. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@peteoz

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

this was submitted as a feature request, not a bug

@peteoz

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

further context.

sometimes I want to fly manual as far as I can (while I'm LOS) and only once entering a terrain where I know I would lose video and radio link (for example when entering canyon) I would like to switch to WP Mission only then (ie. assuming my 1st WP is at the entry of the canyon), but then my 1st WP might be several kilometres away from my actual launch site, under this scenario I wouldn't be even able to arm the model because my 1st WP is too far away.

normally I want to fly model as far as I can in manual mode because still as a pilot I want to have the joy of controlling the plane and also I can get more usable footage out of manually controlled flight, but then once I reach a point in terrain where I know I would lose my video and radio link I would still be happy for the model to continue autonomous mission.

I've been now travelling for 4 weeks in deserts and remote locations around Australia and came across many situations where this requested feature is desirable. for example on my recent flight where I planned to fly through a canyon in autonomous flight and I had to launch and land outside of the national park but the canyon entry was 1.5km away - normally I would've preferred to fly first part of the flight manually and activate WP Mission only at the entry to the canyon, video of the terrain and situation below, incl. the loss of video and radio signal for reference to also show that WP Mission in iNav 2.2 works pretty well even when there is failsafe :
https://youtu.be/XNyx3n-bxEU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.