Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotune might be storing Dgain instead of FFgains #4869

Closed
DzikuVx opened this issue Jun 23, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@DzikuVx
Copy link
Member

commented Jun 23, 2019

Current Behavior

INAV 2.2 Autotune might be storing Dgain instead of FFgains. Not 100% confirmed since it happened only on one of the axises

Steps to Reproduce

  1. Run Autotune
  2. Check gains

Expected behavior

Store FFgains as FFgains and Dgains should be 0 on fixed wings

@issue-label-bot

This comment has been minimized.

Copy link

commented Jun 23, 2019

Issue-Label Bot is automatically applying the label BUG to this issue, with a confidence of 0.86. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@digitalentity

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

Confirmed via reading the code. Fix pending

@CapnBry

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

The D/FF values are also not being logged to Blackbox (#4839), and their setting isn't included in the blackbox info header, nor are they showing in the OSD since the extra field was added to the PID struct. There were a bunch of small things broken by adding this late change that need to be found and cleaned up now.

@digitalentity digitalentity added this to the 2.2.1 milestone Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.