Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inav 2.2 Stable PIDs in OSD do not display FF for fixed wing #4871

Closed
ShawnzAZ opened this issue Jun 24, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ShawnzAZ
Copy link

commented Jun 24, 2019

Current Behavior

PIDs in the OSD just shows 0 for D, does not display FF for Fixed Wing.

image

Steps to Reproduce

  1. Setup Inav for fixed wing
  2. show PIDs in OSD

Expected behavior

I'd expect to see FF values instead of the zeros for D or maybe a 4th column for FF.

Suggested solution(s)

FF value in D column or add a 4th column for FF.

Additional context


  • FC Board name and vendor: Matek F722-Wing
  • INAV version string:

INAV/MATEKF722SE 2.2.0 Jun 18 2019 / 14:53:13 (5e5551b)

GCC-7.3.1 20180622 (release) [ARM/embedded-7-branch revision 261907]

@issue-label-bot issue-label-bot bot added the BUG label Jun 24, 2019

@issue-label-bot

This comment has been minimized.

Copy link

commented Jun 24, 2019

Issue-Label Bot is automatically applying the label BUG to this issue, with a confidence of 0.82. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

fiam added a commit that referenced this issue Jun 24, 2019

[OSD]: Fix display of PIFF FF term
Add pidIndexGetType(), which returns wether a PID controller is
actual PID or PIFF. Use it in osdDisplayPIDValues() to decide
wether to display the D or the FF term.

Fixes #4871

@digitalentity digitalentity added this to the 2.2.1 milestone Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.