Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical alignment of ARMED screen on NTSC #3149

Merged
merged 3 commits into from May 3, 2018

Conversation

Projects
None yet
2 participants
@fiam
Copy link
Member

commented May 2, 2018

Make sure we have enough vertical space to draw all information.

Fixed also a race condition which in some cases initialized the display size incorrectly.

Fixes #3147

fiam added some commits May 2, 2018

Make displayDrawScreen() resync the display if it's not initialized
Display drivers can signal that they haven't completed initialization
by returning that they have 0 rows and/or columns.
Make the max7456 driver return 0 rows and cols before initialization
This way the display layer can update its cached data about the
display once it's fully initialized.
Take into account the display rows when aligning the ARMED screen
Make sure there's enough vertical space to fit all the information.
Fixes #3147

@fiam fiam added this to the 2.0 milestone May 2, 2018

@digitalentity digitalentity merged commit 656f0a6 into development May 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@digitalentity digitalentity deleted the agh_armed_ntsc_fix branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.