Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vbat_max_cell_voltage by the new vbat_cell_detect_voltage setting for detecting number of battery cells #3166

Merged

Conversation

Projects
None yet
2 participants
@shellixyz
Copy link
Collaborator

commented May 5, 2018

No description provided.

@@ -79,6 +79,7 @@ PG_RESET_TEMPLATE(batteryConfig_t, batteryConfig,

.voltage = {
.scale = VBAT_SCALE_DEFAULT,
.cellDetect = 430,

This comment has been minimized.

Copy link
@digitalentity

digitalentity May 5, 2018

Member

Please remember to increase version when adding new parameters to PGs
PG_REGISTER_WITH_RESET_TEMPLATE(batteryConfig_t, batteryConfig, PG_BATTERY_CONFIG, 1);

This comment has been minimized.

Copy link
@shellixyz

shellixyz May 5, 2018

Author Collaborator

Indeed I forgot about the PG version. I think we could also set vbat_max_cell_voltage default to 4.20V now since it is not used for the cell count detection anymore and lower VBATT_CELL_FULL_MAX_DIFF default accordingly to 0.10V.

@digitalentity digitalentity added this to the 2.0 milestone May 5, 2018

@digitalentity

This comment has been minimized.

Copy link
Member

commented May 5, 2018

Also, MSP API and Configurator will have to be modified.

@shellixyz shellixyz force-pushed the shellixyz:add_vbat_cell_detect_voltage branch from fabd9be to 4b286f6 May 5, 2018

Replace vbat_max_cell_voltage by the new vbat_cell_detect_voltage set…
…ting for detecting number of battery cells

@shellixyz shellixyz force-pushed the shellixyz:add_vbat_cell_detect_voltage branch from 4b286f6 to 49b3444 May 5, 2018

@shellixyz

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2018

Should be good for the firmware part

@digitalentity digitalentity merged commit 39de8c5 into iNavFlight:development May 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.