Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send GPS related sensors via S.Port even without a fix #3207

Merged
merged 1 commit into from May 13, 2018

Conversation

Projects
None yet
3 participants
@fiam
Copy link
Member

commented May 12, 2018

Check for feature(FEATURE_GPS) rather than for a GPS fix. This lets
users perform the sensor discovery step without having a GPS fix.

To still allow users to notice if the GPS has stopped working, we
check that either the craft has never been armed or we do have a GPS
fix. This way the sensor is available on startup, but if it stops
working mid-flight the user will get a "sensor lost" alarm.

Send GPS related sensors via S.Port even without a fix
Check for feature(FEATURE_GPS) rather than for a GPS fix. This lets
users perform the sensor discovery step without having a GPS fix.

To still allow users to notice if the GPS has stopped working, we
check that either the craft has never been armed or we do have a GPS
fix. This way the sensor is available on startup, but if it stops
working mid-flight the user will get a "sensor lost" alarm.

@fiam fiam added this to the 2.0 milestone May 12, 2018

@digitalentity digitalentity merged commit 40a95d8 into development May 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@digitalentity digitalentity deleted the agh_sport_gps_sensor_when_configured branch May 13, 2018

@shellixyz

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2018

Good idea. Much better !

alexeystn added a commit to alexeystn/inav that referenced this pull request Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.