Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ROLL/PITCH/YAW PID values blink in the OSD when the corresponding RC adjustment is selected #3252

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
3 participants
@shellixyz
Copy link
Collaborator

commented May 21, 2018

No description provided.

@digitalentity digitalentity added this to the 2.0 milestone May 22, 2018

@@ -521,3 +521,12 @@ void updateAdjustmentStates(void)
}
}
}

bool isAdjustmentFunctionSelected(uint8_t adjustmentFunction) {

This comment has been minimized.

Copy link
@digitalentity

digitalentity May 22, 2018

Member

Calling this all the time is quite expensive. processRcAdjustments alredy iterates though all adjustments each RX cycle. A better way would be to keep track of active adjustment functions there and do a fast query to bitmap or array.

This comment has been minimized.

Copy link
@shellixyz

shellixyz May 22, 2018

Author Collaborator

Are you sure it is really necessary to complicate this ? The OSD is only refreshed every 16ms and adjustmentStates is only 4 cells big (4 maximum simultaneous adjustments). I did not profile this function but to me it the time cost should be low.

@shellixyz shellixyz force-pushed the shellixyz:osd_blink_adjusted_values branch from 58181d2 to e17911b May 22, 2018

@shellixyz shellixyz force-pushed the shellixyz:osd_blink_adjusted_values branch from e17911b to f54d67f May 22, 2018

@fiam fiam merged commit 5156038 into iNavFlight:development Jun 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.