Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC samples averaging with added STM32F30x support #3268

Merged
merged 3 commits into from May 31, 2018

Conversation

Projects
None yet
3 participants
@shellixyz
Copy link
Collaborator

commented May 23, 2018

Duplicate changes made to the F4 ADC driver in #3190 in the F3 ADC driver

Supersedes #3190

@digitalentity
Copy link
Member

left a comment

This PR doesn't enable averaging for any target. Are we going to have a separate PR to do it?

@shellixyz

This comment has been minimized.

Copy link
Collaborator Author

commented May 30, 2018

@digitalentity I can add it to this PR. 20 samples seems to work well. Should we start with this value for both F3 and F4 ?

@shellixyz shellixyz force-pushed the shellixyz:adc_averaging_stm32f3 branch from cc5d800 to 755b7ba May 30, 2018

@shellixyz shellixyz force-pushed the shellixyz:adc_averaging_stm32f3 branch from 755b7ba to 15955b5 May 30, 2018

@shellixyz

This comment has been minimized.

Copy link
Collaborator Author

commented May 30, 2018

I added 20 samples averaging for F3 and F4 targets. Should be good to merge.

@digitalentity digitalentity merged commit 1b0d888 into iNavFlight:development May 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@digitalentity

This comment has been minimized.

Copy link
Member

commented May 31, 2018

@mluessi

This comment has been minimized.

Copy link
Contributor

commented May 31, 2018

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.