Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change year base for RTC time_t to correct leap processing #3307

merged 1 commit into from Jun 1, 2018


None yet
3 participants
Copy link

commented Jun 1, 2018

Modify the base year for RTC time_t calculation in order for the"modulo 4" calculations to work correctly for leap years. The base is 2000 (a leap year) and an offset added / subtracted to get back to the UNIX epoch.

Fixes #3302 (for issue for detail)

mwp log (day is now correct):

2018-06-01T08:12:40+0100 RTC local 2018-06-01T08:12:40.769, fc 2018-06-01T08:12:45.520

BB log, file system time and log remain correct

H Log start datetime:2018-06-01T07:20:02.762+00:00

@stronnag stronnag merged commit 4d5cc76 into development Jun 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@stronnag stronnag deleted the jh_fix_rtc_leap_offset branch Jun 1, 2018

@fiam fiam added this to the 2.0 milestone Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.