Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW: Require turn assistant for nav modes using NAV_CTL_ALT #3379

Merged

Conversation

Projects
None yet
3 participants
@shellixyz
Copy link
Collaborator

commented Jun 16, 2018

No description provided.

@@ -2775,7 +2775,7 @@ bool navigationRequiresTurnAssistance(void)
const navigationFSMStateFlags_t currentState = navGetStateFlags(posControl.navState);
if (STATE(FIXED_WING)) {
// For airplanes turn assistant is always required when controlling position
return (currentState & NAV_CTL_POS);
return (currentState & (NAV_CTL_POS | NAV_CTL_ALT));

This comment has been minimized.

Copy link
@digitalentity

digitalentity Jun 17, 2018

Member

Why is this necessary?

This comment has been minimized.

Copy link
@shellixyz

shellixyz Jun 17, 2018

Author Collaborator

I think it would be better for planes/wings. When trying to maintain altitude it is required to coordinate roll/pitch/yaw. It is not strictly necessary but it would probably give better experience "out of the box" meaning without the user enabling it manually.

@fiam fiam added this to the 2.0 milestone Jun 25, 2018

@fiam fiam merged commit 53110d0 into iNavFlight:development Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.