Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overwrite in osdDisplayPIDValues() which could cause a crash #3408

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@fiam
Copy link
Member

commented Jun 21, 2018

buff was declared as char[3], but 3 digits plus null terminator are
written to it. The variable just before it, might be non-zero in some
cases, causing the string to be not null terminated anymore when it's
passed to displayWriteWithAttr().

Fix stack overwrite in osdDisplayPIDValues() which could cause a crash
buff was declared as char[3], but 3 digits plus null terminator are
written to it. The variable just before it, might be non-zero in some
cases, causing the string to be not null terminated anymore when it's
passed to displayWriteWithAttr().

@fiam fiam added this to the 2.0 milestone Jun 21, 2018

@shellixyz

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2018

Oops nice catch :)

@fiam fiam merged commit 67bcfd4 into development Jun 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fiam fiam deleted the agh_fix_osd_display_pid_values branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.