Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use osdDisplayPIDValues() to draw pitch and roll PIDs #3409

Merged
merged 2 commits into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@fiam
Copy link
Member

commented Jun 21, 2018

Saves 320 bytes of flash in F3

Use osdDisplayPIDValues() to draw pitch and roll PIDs
Saves 384 bytes of flash in F3

@fiam fiam added this to the 2.0 milestone Jun 21, 2018

@fiam

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2018

@shellixyz Take a look at this one, please.

@shellixyz

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2018

Unfortunately it won't work correctly. The PID factors for pitch and roll can be adjusted simultaneously (ADJUSTMENT_PITCH_ROLL_P, ADJUSTMENT_PITCH_ROLL_I, ADJUSTMENT_PITCH_ROLL_D). With this mod the PID factors won't blink when pitch and roll are adjusted simultaneously. We could do this: shellixyz@6a7ea1b. Still saves 320 bytes.

I updated the commit I made a mistake.

@fiam

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2018

@shellixyz Thanks! I've cherry-picked your commit and added it to this PR.

@fiam fiam merged commit de87e8c into development Jun 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fiam fiam deleted the agh_use_osd_display_pid_values branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.