Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better GPS accuracy reading for FrSky telemetry #3446

Merged
merged 2 commits into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@teckel12
Copy link
Contributor

commented Jun 25, 2018

Previously, the GPS accuracy value being sent to FrSky telemetry was basically useless as an HDOP 10 or less was considered the highest accuracy. Basically, this would cause the GPS accuracy to read either 0, the worst, or 9 the best.

With this change, the GPS accuracy is more granular. A value of 9 (the best) is now when the HDOP is 2.0 or less. Each step down for the accuracy value is an HDOP of 0.5 more. So an 8 is from 2.0 to 2.5, 7 us from 2.5 to 3.0, etc. with a 0 being an HDOP higher than 6.0.

This change allows for a more useful reporting of the GPS fix accuracy, better informing the pilot of any potential navigation issues.

Tim Eckel added some commits Jun 25, 2018

Tim Eckel
Tim Eckel
@fiam

This comment has been minimized.

Copy link
Member

commented Jun 26, 2018

@teckel12 Since you're probably the only one using the FrSky telemetry as an API, I think this is safe to merge as soon as it's working for you. Just let us know when it's ready.

@fiam fiam added this to the 2.0 milestone Jun 26, 2018

@teckel12

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2018

@fiam Tested a few times, ready to merge.

I didn't change other telemetry protocols that use the same old useless HDOP logic. But my guess is that few if any are looking at it anyway.

@fiam fiam merged commit 3a56c81 into iNavFlight:development Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.