Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current BB logging and improve battery code #3490

Conversation

Projects
None yet
2 participants
@shellixyz
Copy link
Collaborator

commented Jul 1, 2018

Current sensor offset was not taken into account in BB log so if current_sensor_offset was different from 0 logged current was always wrong.

@shellixyz shellixyz force-pushed the shellixyz:fix_current_bb_loggin_improve_battery_code branch from af93c55 to 0e676c3 Jul 3, 2018

@fiam

This comment has been minimized.

Copy link
Member

commented Jul 5, 2018

@shellixyz looks like this conflicted with the isAmperage() changes. Can you please rebase?

@shellixyz shellixyz force-pushed the shellixyz:fix_current_bb_loggin_improve_battery_code branch from 0e676c3 to 784c1b8 Jul 5, 2018

@shellixyz

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2018

Rebased

@fiam fiam added this to the 2.0 milestone Jul 7, 2018

amperageLatestADC = adcGetChannel(ADC_CURRENT);
amperageLatestADC = pt1FilterApply4(&amperageFilterState, amperageLatestADC, AMPERAGE_LPF_FREQ, timeDelta * 1e-6f);
amperage = currentSensorToCentiamps(amperageLatestADC);
case CURRENT_SENSOR_ADC:;

This comment has been minimized.

Copy link
@fiam

fiam Jul 7, 2018

Member

Extra ';'

@shellixyz shellixyz force-pushed the shellixyz:fix_current_bb_loggin_improve_battery_code branch from 784c1b8 to e311f4a Jul 7, 2018

@fiam fiam merged commit 9043a95 into iNavFlight:development Jul 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.