Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PID controllers output display and logging scaling #3492

Merged

Conversation

Projects
None yet
2 participants
@shellixyz
Copy link
Collaborator

commented Jul 1, 2018

No description provided.

@fiam fiam added this to the 2.0 milestone Jul 3, 2018

@fiam

This comment has been minimized.

Copy link
Member

commented Jul 5, 2018

@shellixyz Why does this PR disable logging of surface PIDs? Even if they're not used right now, they might be used in the near future and it seems likely that we'll forget to re-enable them.

@shellixyz shellixyz force-pushed the shellixyz:fix_PID_output_display_and_logging branch from dab63f0 to d49c624 Jul 5, 2018

@shellixyz

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2018

It was to reduce code size and BB bandwidth but I enabled surface logging again I don't think it matters so much.

@shellixyz shellixyz force-pushed the shellixyz:fix_PID_output_display_and_logging branch from d49c624 to 4baf5fd Jul 6, 2018

@fiam fiam merged commit 2072c74 into iNavFlight:development Jul 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.