Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests, require them to pass in Travis checks #3504

merged 8 commits into from Jul 3, 2018


None yet
1 participant
Copy link

commented Jul 2, 2018

No description provided.

fiam added some commits Jul 2, 2018

Fix sensor alignment tests
alignSensors() was renamed to applySensorAlignment() and now takes
3 arguments.
Fix math unit tests
- fp_vector is now fpVector3_t
- Vector rotation is now done via matrix rather than using rotateV
Fix gyro unit tests
gyroUpdate(void) changed gyroUpdate(timeDelta_t)

Also, gyro_sync driver no longer exists
Fix hott telemetry unit tests
openSerial() and getAmperage() needed prototype changes
Disable rcdevice tests
Unit test now compiles, but unfortunately it seems that the tests
are incorrectly mocking the device responses and a new driver is
on the way, so there's no reason to fix this test for now.
Require test to actually pass when running make test
The Makefile was returning success via || true even if the tests
failed to run.

@fiam fiam added this to the 2.0 milestone Jul 2, 2018

fiam added some commits Jul 2, 2018

Add missing include in CMS menus that reference setting IDs
Header was accidentally included by cms/cms.h
Make calculateRxChannelsAndUpdateFailsafe() return true at the end
This makes it return true when the channels have been updated

@fiam fiam merged commit 6ac165c into development Jul 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@fiam fiam deleted the agh_fix_tests branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.