Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gyro temperature element in OSD #3978

Merged
merged 9 commits into from Nov 24, 2018

Conversation

Projects
None yet
5 participants
@nmaggioni
Copy link
Contributor

commented Nov 2, 2018

This PR adds the temperature of the FC's gyro to the OSD as requested in #2848.

The relative PR for the configurator is: iNavFlight/inav-configurator#592

@nmaggioni nmaggioni force-pushed the nmaggioni:osd_temperature branch from 7fbd7e0 to c13056b Nov 2, 2018

@nmaggioni nmaggioni force-pushed the nmaggioni:osd_temperature branch from c13056b to 062289d Nov 2, 2018

Reduce temperature precision in OSD
No more decimals (nn.n °C -> nn °C)
@nmaggioni

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2018

I've reduced the precision of the element as suggested by other devs. Decimals aren't really needed and take up precious screen space.

Those who need such precision can easily revert cde66d1: I don't think it's worth adding a user-facing setting for this, but I'm open to suggestions.

@nmaggioni nmaggioni changed the title Gyro temperature element in OSD [WIP] Gyro temperature element in OSD Nov 5, 2018

@nmaggioni nmaggioni force-pushed the nmaggioni:osd_temperature branch from a7e4e0f to 7bd6f87 Nov 5, 2018

@nmaggioni nmaggioni changed the title [WIP] Gyro temperature element in OSD Gyro temperature element in OSD Nov 5, 2018

@nmaggioni

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

Rebased on new temperature framework, should be ready to merge now.

@digitalentity digitalentity requested a review from fiam Nov 5, 2018

@digitalentity

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

@fiam can you please review?

Show resolved Hide resolved src/main/cms/cms_menu_osd.c Outdated
Show resolved Hide resolved src/main/io/osd.c Outdated
Show resolved Hide resolved src/main/io/osd.c Outdated
Show resolved Hide resolved src/main/io/osd.h Outdated
Show resolved Hide resolved src/main/io/osd.c Outdated
Show resolved Hide resolved src/main/io/osd.c Outdated

nmaggioni added some commits Nov 6, 2018

@nmaggioni

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2018

@fiam ✔️

To avoid messing with the configurator's PRs, this will need to be merged after #3941 - most probably after I rebase on it.

@fiam

fiam approved these changes Nov 18, 2018

@nmaggioni

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2018

Rebased and ready to merge.

@digitalentity digitalentity merged commit f3b121f into iNavFlight:development Nov 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nmaggioni nmaggioni deleted the nmaggioni:osd_temperature branch Dec 11, 2018

@putimir

This comment has been minimized.

Copy link

commented Feb 3, 2019

Hey! Is it too much to ask, if you can add some sort of simple offset setting in cli, in order that we can modify the measured temp to compensate error from the FC being closed in so me fuselage (wings, planes...). I'm interested in outside temps, especially when flying high up :)

Thanks for looking.

@shellixyz

This comment has been minimized.

Copy link
Collaborator

commented Feb 3, 2019

@putimir See #4282

@nmaggioni

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

@putimir Using the onboard sensor won't work since the FC's temperature isn't constant; you can easily check that by leaving it turned on on the ground for a few moments: it will gradually heat up and the readings will be affected by multiple external conditions. The onboard sensor is mostly used as an indicator of the FC's health so far (that is to say: it represents your craft's electronic's temperature).

Also check #3844 for hw discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.