Prevent incorrect rescheduling for BMP280 baro dummy ut_delay #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this will also solve #586, both the affected vehicles have BMP280, whilst my BMP180 craft is unaffected.Will test later today. |
|
Flew 4 lipos / 7 distinct flights / one hour air time with this on 1.2.0 master and saw no instance of the random #586 behaviour. I'm more likely to believe that fixes #586 than anything to do with 0f63bc6, as this fix would explain the mid-flight behaviour of #586 observed once. More testing tomorrow on the other BMP280 platform. |
|
This is good news. I was puzzled as to how 0f63bc6 could cause the problem. |
|
Please also consider back porting this into master (and a point release, it's bad news for BMP280 users). |
|
I'm going to merge #614 and start towards an intermediate 1.2.1 release. |
Closed
digitalentity
pushed a commit
that referenced
this pull request
Sep 18, 2016
(cherry picked from commit 79fdc6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.