Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD AHI pitch interval redraw option #7018

Merged
merged 8 commits into from Nov 19, 2022

Conversation

breadoven
Copy link
Collaborator

@breadoven breadoven commented May 24, 2021

Provides an option to draw the AHI at set pitch intervals throughout the full pitch range. The interval can be set from 1 to 30 degrees with the option disabled when set to 0. Default value is 10 degrees.

The AHI is drawn normally until pitch exceeds the set pitch interval after which it is drawn with the ends offset. The offset increases with increasing pitch and changes direction between climb and descent. The offset doesn't work for roll angles > 45 degrees simply because it becomes too distorted to be much use.

https://www.youtube.com/watch?v=h_iYlMv_4OA

@shellixyz
Copy link
Collaborator

Cool idea

@stale
Copy link

stale bot commented Jan 9, 2022

This issue / pull request has been automatically marked as stale because it has not had any activity in 60 days. The resources of the INAV team are limited, and so we are asking for your help.
This issue / pull request will be closed if no further activity occurs within two weeks.

@stale stale bot added the Inactive label Jan 9, 2022
@DzikuVx DzikuVx removed the Inactive label Jan 9, 2022
@stale
Copy link

stale bot commented Apr 18, 2022

This issue / pull request has been automatically marked as stale because it has not had any activity in 60 days. The resources of the INAV team are limited, and so we are asking for your help.
This issue / pull request will be closed if no further activity occurs within two weeks.

@stale stale bot added the Inactive label Apr 18, 2022
@b14ckyy
Copy link
Collaborator

b14ckyy commented Oct 29, 2022

Is there a reason why this was never merged? :O

@breadoven
Copy link
Collaborator Author

Is there a reason why this was never merged? :O

No reason really. Wasn't sure there was that much interest in it so it got overlooked I guess. Have you tried it ? I did notice occasional momentary ghosting of the horizon elements but otherwise it works as expected. Could be merged if required as is.

@b14ckyy
Copy link
Collaborator

b14ckyy commented Oct 30, 2022

As I understand the feature is optional right? if you resolve the conflicts I'd be happy to test it in flight.
I really like it and I can ask in the community if they want that too.
needs testing for the digital OSDs for sure.

@b14ckyy
Copy link
Collaborator

b14ckyy commented Oct 30, 2022

Yep people seem to like it so far, based on the first comments :D
I will load it on my Dart 250G and test on analog. 2 of my 6.0 Test pilots will test it on DJI WTF.os. Walksnail and HDZero TBD later.

@b14ckyy
Copy link
Collaborator

b14ckyy commented Oct 30, 2022

Tested analog today and looks good so far. https://youtu.be/8673w1ZInW4
But I suggest turning it off by default and make it an opt in feature. also adding a recommended value of 20 as a starting point as 10 is too narrow for each redraw. It does not use the full available AHI area and loops at too small angles already.

waiting for the Digital pilots to test.

One thing I am checking now is, that after flashing the artefact build to my F411-WSE I got MSP issues. 2 Packet errors per second and very slow MSP data transfer. F405SE does not seem to be affected. Will test another F411 and give feedback. Maybe something went wrong during rebase?

@breadoven
Copy link
Collaborator Author

Was there any final conclusion on merging this or not ?

@b14ckyy
Copy link
Collaborator

b14ckyy commented Nov 19, 2022

No feedback from the digital pilots yet because they had not much flight time recently but see no point why it would not work.
With the feature off by default I think it can be merged and during next test release we will know if it works there as well.

@breadoven breadoven added this to the 6.0 milestone Nov 19, 2022
@breadoven breadoven merged commit 5423d66 into iNavFlight:master Nov 19, 2022
@breadoven breadoven deleted the abo_ahi_pitch_interval_option branch November 20, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants