Issue 142 #146
Issue 142 #146
Conversation
Merging v3.0 changes to master
Merging v3.0 changes to master
Merging v3.0 changes to master
|
Updated. |
|
@countrdd We have checked fixed issues and give update with new found issues. We have reported all the issues in, |
|
I must not be pusing this write, because it is fine on my systems….for all the erros you said.hmmmm From: ASTPP Development notifications@github.com @countrddhttps://github.com/countrdd We have checked fixed issues and give update with new found issues. We have reported all the issues in, — |
|
@countrdd, I am sure it must be working perfect in your setup with proper data. While we are getting contribution from someone, that is our duty to verify the code and features with proper and improper data and once everything fine release it under the open source version. So that community not get buggy contributions and they can adopt new changes without hassle. So far the feature which you have implemented will really be going to useful to all admins as they will no longer require to format the csvs to import the termination rates. |
|
I agree, I should have been more clear, the format changes for the screen (i.e. html) looked like what you have pointed out, and I fixed that and for some reason I am cannot seem to push that up…
I am really looking forward to getting these in and figuring out what I am doing wrong with the pull request, that way I can contribute more.
Dusty
From: Samir Doshi <notifications@github.com>
Reply-To: iNextrix/ASTPP <reply@reply.github.com>
Date: Thursday, November 24, 2016 at 8:02 AM
To: iNextrix/ASTPP <ASTPP@noreply.github.com>
Cc: Dustian Countryman <countrdd@leillc.net>, Mention <mention@noreply.github.com>
Subject: Re: [iNextrix/ASTPP] Issue 142 (#146)
@countrdd<https://github.com/countrdd>, I am sure it must be working perfect in your setup with proper data. While we are getting contribution from someone, that is our duty to verify the code and features with proper and improper data and once everything fine release it under the open source version. So that community not get buggy contributions and they can adopt new changes without hassle.
So far the feature which you have implemented will really be going to useful to all admins as they will no longer require to format the csvs to import the termination rates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#146 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADVysmJ8bounHCKASC-HsZcDuyDuKoWUks5rBYrygaJpZM4Kovls>.
|
|
See here is where it looks ok
From: Samir Doshi <notifications@github.com>
Reply-To: iNextrix/ASTPP <reply@reply.github.com>
Date: Thursday, November 24, 2016 at 8:02 AM
To: iNextrix/ASTPP <ASTPP@noreply.github.com>
Cc: Dustian Countryman <countrdd@leillc.net>, Mention <mention@noreply.github.com>
Subject: Re: [iNextrix/ASTPP] Issue 142 (#146)
@countrdd<https://github.com/countrdd>, I am sure it must be working perfect in your setup with proper data. While we are getting contribution from someone, that is our duty to verify the code and features with proper and improper data and once everything fine release it under the open source version. So that community not get buggy contributions and they can adopt new changes without hassle.
So far the feature which you have implemented will really be going to useful to all admins as they will no longer require to format the csvs to import the termination rates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#146 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADVysmJ8bounHCKASC-HsZcDuyDuKoWUks5rBYrygaJpZM4Kovls>.
|
|
Sorry, Got busy. I think everything is there, just need to know if I need to do anything else. |
Adding option to import termination rates using a column mapper