Use company favicon #472
Merged
Use company favicon #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use company favicon from Portal section of Company profile page in login.
|
Hi @aikajee Thanks for the contribution. |
|
Hi,
The login screen does not display the uploaded favicon. It defaults to the
standard ASTPP favicon. The small fix, taken from the dashboard view fixes
the issue by checking for the custom uploaded favicon and if found uses it.
If not found, it defaults to the standard ASTPP favicon.
Regards,
Ahmed.
…On Mon, Nov 19, 2018 at 6:40 AM Samir Doshi ***@***.***> wrote:
Hi @aikajee <https://github.com/aikajee>
Thanks for the contribution.
would you please explain what issue it will resolve exactly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#472 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ArBvPczOU6Tr52-On9T0-8MkYbWr-EYYks5uwpiwgaJpZM4YnVGm>
.
--
|
|
Thanks. Merged!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use company favicon from Portal section of Company profile page in login.