From c1df6fa59a745d029bec733dbbe2d5eea0138213 Mon Sep 17 00:00:00 2001 From: Caleb German Date: Thu, 20 Mar 2025 10:52:55 -0500 Subject: [PATCH 1/4] Fixed css for property-comparison-table-slider --- .../src/contentviews/PropertyComparisonTable.scss | 10 +++------- .../src/contentviews/PropertyComparisonTable.tsx | 1 + 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss index 9d57ac19..fe1cb0e7 100644 --- a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss +++ b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss @@ -33,15 +33,11 @@ } } - > .iui-slider-component-container { - width: 100%; - justify-content: center; - - .iui-slider-container { - min-width: 200px; + >.imodel-slider { + width: 100%; max-width: 600px; + min-width: 200px; } - } > .settings { grid-area: settings; diff --git a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx index 1b96fc7f..143f1b75 100644 --- a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx +++ b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx @@ -587,6 +587,7 @@ interface OverviewOpacitySliderProps { function OverviewOpacitySlider(props: OverviewOpacitySliderProps) { return ( Date: Thu, 20 Mar 2025 10:59:18 -0500 Subject: [PATCH 2/4] Added changeset --- .changeset/three-stars-bake.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/three-stars-bake.md diff --git a/.changeset/three-stars-bake.md b/.changeset/three-stars-bake.md new file mode 100644 index 00000000..644fa8fc --- /dev/null +++ b/.changeset/three-stars-bake.md @@ -0,0 +1,5 @@ +--- +"@itwin/changed-elements-react": patch +--- + +- Fixed CSS for property comparison table slider From a72044f4a69a77c9b37f6ca7d276c4ff9872604c Mon Sep 17 00:00:00 2001 From: Caleb German Date: Thu, 20 Mar 2025 12:03:05 -0500 Subject: [PATCH 3/4] Updated scss --- .../src/contentviews/PropertyComparisonTable.scss | 12 ++++++++---- .../src/contentviews/PropertyComparisonTable.tsx | 1 - 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss index fe1cb0e7..eade36e4 100644 --- a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss +++ b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss @@ -33,11 +33,15 @@ } } - >.imodel-slider { - width: 100%; - max-width: 600px; + > [class*="slider-container"] { + width: 100%; + justify-content: center; + max-width: 800px; + [class$="-slider"] { + max-width: 100%; min-width: 200px; - } + } + } > .settings { grid-area: settings; diff --git a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx index 143f1b75..1b96fc7f 100644 --- a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx +++ b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.tsx @@ -587,7 +587,6 @@ interface OverviewOpacitySliderProps { function OverviewOpacitySlider(props: OverviewOpacitySliderProps) { return ( Date: Thu, 20 Mar 2025 12:03:21 -0500 Subject: [PATCH 4/4] Fixed indents --- .../src/contentviews/PropertyComparisonTable.scss | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss index eade36e4..d19bb2d8 100644 --- a/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss +++ b/packages/changed-elements-react/src/contentviews/PropertyComparisonTable.scss @@ -33,14 +33,14 @@ } } - > [class*="slider-container"] { + > [class*="slider-container"] { width: 100%; justify-content: center; max-width: 800px; - [class$="-slider"] { + [class$="-slider"] { max-width: 100%; min-width: 200px; - } + } } > .settings { @@ -58,21 +58,22 @@ /* Override status positive color */ .added-row { > :first-child { - box-shadow: inset .4rem 0 0 0 var(--iui-color-background-positive-hover); + box-shadow: inset 0.4rem 0 0 0 var(--iui-color-background-positive-hover); } } /* Override status warning color */ .modified-row { > :first-child { - box-shadow: inset .4rem 0 0 0 var(--iui-color-background-informational-hover); + box-shadow: inset 0.4rem 0 0 0 + var(--iui-color-background-informational-hover); } } /* Override status warning color */ .removed-row { > :first-child { - box-shadow: inset .4rem 0 0 0 var(--iui-color-background-negative-hover); + box-shadow: inset 0.4rem 0 0 0 var(--iui-color-background-negative-hover); } } }