Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent node sizing on load #253

Closed
ugurdogrusoz opened this issue Jun 21, 2021 · 3 comments
Closed

Inconsistent node sizing on load #253

ugurdogrusoz opened this issue Jun 21, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ugurdogrusoz
Copy link
Contributor

If you save a pathway and load it back some other time into a PM with a different experiment data set, we get inconsistently sized nodes (neither the same as the time they were saved, nor properly fitting the experiment data set at hand on load).

At the time of save:
Screenshot 2021-06-21 110157

Upon load into another PM instance with different experiment data set:
Screenshot 2021-06-21 110306

@ugurdogrusoz ugurdogrusoz added the bug Something isn't working label Jun 21, 2021
@ugurdogrusoz ugurdogrusoz added this to the 2.2 milestone Jun 21, 2021
msalihaltun added a commit that referenced this issue Jun 22, 2021
@msalihaltun
Copy link
Contributor

With these changes we will stop overriding the stylesheet width value with "ideal width such that study information boxes can fit" whenever we have study data loaded. Instead we change data width properties of nodes to the ideal value only when studies are first being loaded. This way there won't be inconsistent resizing of nodes on import/export. Instead nodes can be resized to content from the menu whenever desired.

@ugurdogrusoz
Copy link
Contributor Author

It's good that we do not resize them on load but now we lose the experiment data though. Even though there is data associated with certain genes, we don't show them on load:
Screenshot 2021-06-22 173127

@msalihaltun
Copy link
Contributor

This is not actually about resizing nodes, it is related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants