Skip to content

Remove @ensured_* variables. #5

Merged
merged 2 commits into from Feb 7, 2013

2 participants

@maxim
maxim commented Aug 15, 2012

When running different run lists per role, @ensured_* variables are not refreshed, and for example, roundsman thinks it already created /tmp/roundsman, but that's not the case, since we're contacting a different host now. Since the ensure operations are quick and idempotent, no need to go extra mile just to skip them.

@maxim maxim Remove @ensured_* cache variables.
When running different run lists per role, @ensured_* variables are not refreshed, and for example, roundsman thinks it already created /tmp/roundsman, but that's not the case, since we're contacting a different host now. Since the ensure operations are quick and idempotent, no need to go extra mile just to skip them.
f8c8de1
@maxim
maxim commented Aug 16, 2012

I see that without @ensured_* these checks run a few times per deploy. I think it's still better than broken per-role functionality, but best to find some way to also fix that.

@maxim maxim Merge remote-tracking branch 'upstream/master'
Conflicts:
	lib/roundsman/capistrano.rb
7bd230c
@Arie Arie merged commit b3e091e into iain:master Feb 7, 2013
@Arie
Collaborator
Arie commented Feb 7, 2013

Thanks for fixing this, sorry it took so long to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.