New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple updates #2

Merged
merged 8 commits into from Sep 27, 2015

Conversation

Projects
None yet
2 participants
@garu
Contributor

garu commented Apr 29, 2015

Hello!

First of all, thank you for creating such a nice distribution. I did not know about ServerStatus modules before, and think they are a nice addition to web projects.

It came to my attention that your repository was completely empty but for a boilerplate README :(
So I got around and added the same files from version 0.02 (which you uploaded to CPAN). It is my first commit of this pull request: 64214ce

I also updated the README and Makefile.PL to include extra information about this repository, dependencies, etc. I usually do those each in a different branch, but since the "master" branch was empty, I was not able to do so (sorry!), so I tried hard to make each change in a single commit.

If you have any questions, please feel free to ask away!

I'd love to see this merged and released to CPAN as version 0.03 - I even added a Changes file, which was also missing, so please make sure to update the date of the release in there :)

The source code itself is exactly the same as 0.02 (from CPAN), except for:

  • $VERSION was bumped from 0.02 to 0.03;
  • the use Net::CIDR; line was removed as it was not needed and triggering several errors on CPAN Testers);
  • Some bits of the documentation were reworded a bit, mostly to fix typos;

Thanks again

@@ -0,0 +1,12 @@
Revision history for Mojolicious-Plugin-ServerStatus
0.03 2015-04-30

This comment has been minimized.

@garu

garu Apr 29, 2015

Contributor

@iakuf please update this date whenever you make the release to CPAN :)

@garu

garu Apr 29, 2015

Contributor

@iakuf please update this date whenever you make the release to CPAN :)

- removed unneeded dependencies
0.02 2014-03-19
- improved query string handling

This comment has been minimized.

@garu

garu Apr 29, 2015

Contributor

I got this from MetaCPAN's diff tool. Please change it if I got it wrong :)

@garu

garu Apr 29, 2015

Contributor

I got this from MetaCPAN's diff tool. Please change it if I got it wrong :)

@garu garu referenced this pull request Apr 29, 2015

Closed

No source, only a readme #1

iakuf added a commit that referenced this pull request Sep 27, 2015

@iakuf iakuf merged commit 406062e into iakuf:master Sep 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment