Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Emoji 12.1 #165

Merged
merged 57 commits into from Jan 11, 2020
Merged

Support for Emoji 12.1 #165

merged 57 commits into from Jan 11, 2020

Conversation

@iamcal
Copy link
Owner

iamcal commented Jan 9, 2020

This is the PR where I'm working on support for the latest Emoji version.

Currently the source data is up to date, but the build_map.php step is showing some errors.

After the data processing is complete, I can start working on updating the image sets,

iamcal added 8 commits Jan 9, 2020
…to be skipped when checking for coverage.

they are listed multiple times, with the component part coming later, so first build a list a possible missing and skips, then process them all
…dorra', so trim off the prefix before adding ' Flag' to the end of the name
@iamcal

This comment has been minimized.

Copy link
Owner Author

iamcal commented Jan 9, 2020

Only a couple of overlapping sequences/names to fix in the basic data now

@iamcal

This comment has been minimized.

Copy link
Owner Author

iamcal commented Jan 9, 2020

Just apple image remain to be extracted, then I'll need to build sheets and optimize all the images.

Facebook messenger images have been removed - Facebook have unified into a single image set (EMOJI_3) and this is now used.

@iamcal

This comment has been minimized.

Copy link
Owner Author

iamcal commented Jan 10, 2020

Thanks James - this branch now fixes both of those issues. The mixed-skin-tone couples were added in 12.1, so i'm going to work on those next. After they are complete i'll need to rebuild all the sheets too.

@jwheare

This comment has been minimized.

Copy link
Contributor

jwheare commented Jan 10, 2020

We can also get the non-mixed skin tone variations on gender-neutral people_holding_hands by changing in data_emoji_names_v12.txt:

1F9D1-200D-1F91D-200D-1F9D1;people_holding_hands
to:
1F9D1{SKIN}-200D-1F91D-200D-1F9D1{SKIN};people_holding_hands

@jwheare

This comment has been minimized.

Copy link
Contributor

jwheare commented Jan 10, 2020

I've been poking around with the mixed skin tone stuff. It's tricky because of the :skin-1 suffix style shortnames. I was toying with using something like :skin-1-skin-2 but didn't get very far.

@jwheare

This comment has been minimized.

Copy link
Contributor

jwheare commented Jan 10, 2020

@iamcal

This comment has been minimized.

Copy link
Owner Author

iamcal commented Jan 10, 2020

i have a similar patch locally - not sure i'll have time to iterate on it today, but maybe!

@iamcal

This comment has been minimized.

Copy link
Owner Author

iamcal commented Jan 11, 2020

i think it's close to complete. i'm rebuilding the sheets now, which takes a few hours, and then it should be good to release

i'm bumping the major version number (to 5.0.0) since the multiple-skin-tones-per-emoji changes makes the skin variation keys non-backward-compatible

@iamcal iamcal merged commit 0f159ac into master Jan 11, 2020
1 check passed
1 check passed
security/snyk - package.json (iamcal) No new issues
Details
@iamcal iamcal deleted the v12 branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.