fix: Serbian locale grammar (sr, sr-cyrl) #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same update of formats that has been done about a month ago on Moment.js. Regarding the grammar, there was no logic for different grammar cases for the nouns. This is added by adding very precise logic for determining grammar cases by the `number`, `isFuture` and `withoutPreffix` parameters. The same update has been submitted to Moment.js.
Codecov Report
@@ Coverage Diff @@
## dev #1108 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 172 172
Lines 1547 1579 +32
Branches 328 343 +15
=========================================
+ Hits 1547 1579 +32
Continue to review full report at Codecov.
|
|
|
|
LGTM |
iamkun
pushed a commit
that referenced
this pull request
Oct 13, 2020
## [1.9.2](v1.9.1...v1.9.2) (2020-10-13) ### Bug Fixes * add arraySupport plugin ([#1129](#1129)) ([be505c2](be505c2)) * export type of duration plugin ([#1094](#1094)) ([2c92e71](2c92e71)) * Fix LocaleData plugin longDateFormat lowercase error ([#1101](#1101)) ([7937ccd](7937ccd)) * Fix objectSupport plugin bug in UTC ([#1107](#1107)) ([fe90bb6](fe90bb6)), closes [#1105](#1105) * fix Serbian locale grammar (sr, sr-cyrl) ([#1108](#1108)) ([cc87eff](cc87eff)) * Fix typo for "monday" in arabic ([#1067](#1067)) ([2e1e426](2e1e426)) * support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](#1099)) ([b1a0294](b1a0294)) * update Breton [br] locale relativeTime config ([#1103](#1103)) ([b038bfd](b038bfd)) * update Catalan [ca] locale ordinal ([73da380](73da380)) * update German [de] locale relativeTime config ([#1109](#1109)) ([f6e771b](f6e771b)) * update localeData plugin to add longDateFormat to global localeData ([#1106](#1106)) ([16937d1](16937d1)) * Update objectSupport plugin to return current date time while parsing empty object ([f56783e](f56783e))
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13) ### Bug Fixes * add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2)) * export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71)) * Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd)) * Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105) * fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff)) * Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426)) * support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294)) * update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd)) * update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380)) * update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b)) * update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1)) * Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13) ### Bug Fixes * add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2)) * export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71)) * Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd)) * Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105) * fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff)) * Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426)) * support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294)) * update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd)) * update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380)) * update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b)) * update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1)) * Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Serbian locale grammar since current logic doesn't account for different cases in different tenses (past and future) and no tenses (without suffix) alongside long date formats that have already been fixed in Moment.js.
The same logic has been sent as a PR for Moment.js moment/moment#5742 where fixes are described a little bit more.