locally changing locale is immutable, docs update #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 275 275
Branches 48 47 -1
=====================================
Hits 275 275
Continue to review full report at Codecov.
|
iamkun
changed the title
|
Hi, @ohbarye @ludvon In order to keep the same behavior with other APIs, I've changed And also updated one line of the English doc like this: Changing locales locally
- Returns a new Dayjs object by switching to new locale.For less confusion, would you please update your Docs if you have some free time? Cheers. |
|
🎉 This PR is included in version 1.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ohbarye
added a commit
to ohbarye/dayjs
that referenced
this pull request
May 21, 2018
to reflect this change: iamkun#182 (comment)
|
@iamkun The wording in my translation already implied it was immutable, so I don't need to change it. |
|
@ludvon great! |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
<a name="1.6.3"></a> ## [1.6.3](iamkun/dayjs@v1.6.2...v1.6.3) (2018-05-21) ### Bug Fixes * Changing locales locally is immutable from this release ([2cce729](iamkun/dayjs@2cce729)), closes [#182](iamkun/dayjs#182) * instance locale change should be immutable ([84597c9](iamkun/dayjs@84597c9))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
to reflect this change: iamkun/dayjs#182 (comment)
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
<a name="1.6.3"></a> ## [1.6.3](iamkun/dayjs@v1.6.2...v1.6.3) (2018-05-21) ### Bug Fixes * Changing locales locally is immutable from this release ([2cce729](iamkun/dayjs@2cce729)), closes [#182](iamkun/dayjs#182) * instance locale change should be immutable ([84597c9](iamkun/dayjs@84597c9))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
to reflect this change: iamkun/dayjs#182 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.