Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): add missing locale type definitions #716

Merged
merged 2 commits into from Dec 9, 2019
Merged

Conversation

@JounQin
Copy link
Contributor

JounQin commented Nov 4, 2019

@iamkun This PR improves locale user experience for TypeScript users, please help to review.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #716 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #716   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines      1017   1017           
  Branches    157    157           
===================================
  Hits       1017   1017

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d2f02...78e8144. Read the comment docs.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 6, 2019

@iamkun Any time to review this?

types/index.d.ts Show resolved Hide resolved
@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 18, 2019

???@iamkun What's going on? Can you please take care of this?

@iamkun

This comment has been minimized.

Copy link
Owner

iamkun commented Nov 18, 2019

We will merge all the incoming features before the next release, thanks for your concern.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 18, 2019

@iamkun I saw you're merging other PRs during these days, so I was thinking is there anything wrong with this PR.

@iamkun

This comment has been minimized.

Copy link
Owner

iamkun commented Nov 18, 2019

Oh, I see, the PRs get merged quickly are all chore fix.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 18, 2019

Well, follow your own schedule then. Cheers. 🍺

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Dec 9, 2019

@iamkun Sorry I have to asking for releasing it again here, it is really needed...

@iamkun

This comment has been minimized.

Copy link
Owner

iamkun commented Dec 9, 2019

@JounQin let's make it merged today!

@iamkun iamkun merged commit cde5d0b into iamkun:dev Dec 9, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 30d2f02...78e8144
Details
codecov/project 100% remains the same compared to 30d2f02
Details
@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Dec 9, 2019

@iamkun Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.