Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adds option not to run indefinitely. #2

Merged
merged 2 commits into from Feb 16, 2013

Conversation

Projects
None yet
2 participants
Contributor

cloud8421 commented Feb 11, 2013

Hello,

I've added an option not to run indefinitely. The use case, which is temporary considering the grunt 0.4.0 release (where this behaviour can be achieved by the contrib-server task), is to run different servers (like for tests) on different ports.

Defaults to run indefinitely, but can be changed as shown in the readme.

Owner

iammerrick commented Feb 11, 2013

So grunt won't shut this down until all the other tasks are finished running?

Contributor

cloud8421 commented Feb 11, 2013

The default behaviour will be identical to the current one. Passing the option with the false flag will make it behave like the default grunt server, it will run until grunt shuts down.

If you start before a watcher, it will run until you kill the watcher. If you run it before a test command like jasmine it will terminate together with jasmine.

Contributor

cloud8421 commented Feb 13, 2013

Any extra thoughts?

Owner

iammerrick commented Feb 13, 2013

Yes, can you change it to keepalive (for consistency with the upcoming grunt-contrib-connect? I can do it later after the merge but thats the only thing keeping me. :-)

Thanks for this work btw.

M

Contributor

cloud8421 commented Feb 13, 2013

Will do and push. Thanks!

Contributor

cloud8421 commented Feb 14, 2013

Done!

Owner

iammerrick commented Feb 16, 2013

You rock. Thank you!

iammerrick added a commit that referenced this pull request Feb 16, 2013

@iammerrick iammerrick merged commit 55bb60e into iammerrick:master Feb 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment