New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken coverage. #15

Merged
merged 1 commit into from Nov 23, 2015

Conversation

Projects
None yet
2 participants
@denysdovhan
Copy link
Contributor

denysdovhan commented Nov 22, 2015

Just fix broken coverage.

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 23, 2015

can you show projects with this coverage script working properly?

@denysdovhan

This comment has been minimized.

Copy link
Contributor

denysdovhan commented Nov 23, 2015

Sure https://github.com/denysdovhan/mdast-typographer
It doesn't work perfect, but it works.

iamstarkov added a commit that referenced this pull request Nov 23, 2015

@iamstarkov iamstarkov merged commit 98ba211 into iamstarkov:master Nov 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 23, 2015

Thank you

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

unfortunately i’m still getting No coverage information was collected, exit without writing coverage information

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

coverage is not working with mdast-typographer neither

➜  mdast-typographer git:(master) npm run coverage

> mdast-typographer@0.2.0 coverage /Users/vlasta/projects/mdast-typographer
> babel-node ./node_modules/.bin/isparta cover _mocha index.js -- --require babel-core/register



  mdast-typographer
    ✓ should transform (48ms)
    ✓ should remove disabled transformers
    ✓ should remove all transformers
    ✓ should load locale
    ✓ should use after transformers
    ✓ should use before transformers
    ✓ should use after and before transformers


  7 passing (99ms)

No coverage information was collected, exit without writing coverage information
@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

so its coverage is broken, on the other hand its exactly in the same state as before

@denysdovhan

This comment has been minimized.

Copy link
Contributor

denysdovhan commented Nov 24, 2015

WTF?
It was working for me.

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

maybe its my bad

➜  mdast-typographer git:(master) node -v && npm -v
v0.10.40
1.4.28
@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

but its not

➜  mdast-typographer git:(master) n latest
➜  mdast-typographer git:(master) node -v && npm -v
v5.1.0
3.3.12
➜  mdast-typographer git:(master) npm run coverage

> mdast-typographer@0.2.0 coverage /Users/vlasta/projects/mdast-typographer
> babel-node ./node_modules/.bin/isparta cover _mocha index.js -- --require babel-core/register



  mdast-typographer
    ✓ should transform (74ms)
    ✓ should remove disabled transformers
    ✓ should remove all transformers
    ✓ should load locale
    ✓ should use after transformers
    ✓ should use before transformers
    ✓ should use after and before transformers


  7 passing (148ms)

No coverage information was collected, exit without writing coverage information
@denysdovhan

This comment has been minimized.

Copy link
Contributor

denysdovhan commented Nov 24, 2015

Nope. Not sure.

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

i got it working here iamstarkov/some8@620c46f

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

screen shot 2015-11-24 at 19 33 49

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 24, 2015

fixed and published as v1.1.8

@denysdovhan

This comment has been minimized.

Copy link
Contributor

denysdovhan commented Nov 24, 2015

Win 👍

@denysdovhan denysdovhan deleted the denysdovhan:patch-1 branch Nov 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment