New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with ! and ? #4

Merged
merged 1 commit into from Nov 21, 2015

Conversation

Projects
None yet
2 participants
@denysdovhan
Copy link
Contributor

denysdovhan commented Nov 18, 2015

Small but important fix.

If you try to process strings with ! or ? then you'll see that nothing happends:

Hello, "world"! --> Hello, "world"!
Hello, "world"? --> Hello, "world"!

It works only for . and ,. This request fixes that problem.

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 19, 2015

looks good. will take a deeper look later today

@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 21, 2015

looks good. will take a deeper look later today

@

2 days ago

sorry, it was hard week. seems legit

iamstarkov added a commit that referenced this pull request Nov 21, 2015

Merge pull request #4 from denysdovhan/patch-1
Fix problem with ! and ?

@iamstarkov iamstarkov merged commit ef3c233 into iamstarkov:master Nov 21, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@iamstarkov

This comment has been minimized.

Copy link
Owner

iamstarkov commented Nov 21, 2015

sorry, cannot publish now, cause babel errors again

@denysdovhan

This comment has been minimized.

Copy link
Contributor

denysdovhan commented Nov 21, 2015

Not problem, I'll be waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment